Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): remove no longer used v2/yarn.lock #510

Conversation

agilgur5
Copy link
Member

@agilgur5 agilgur5 commented Jan 6, 2024

Motivation

  • v2's deps were merged with v1 in feat: merge v1 and v2 #153
    • the package.json was removed there, but looks like the yarn.lock was left in

Noticed this in #432 (comment)

Modifications

  • remove v2/yarn.lock

Verification

It has no matching package.json, so it is unused/unuseable.

- v2's deps were merged with v1 in c25c690
  - the `package.json` was removed there, but looks like the `yarn.lock` was left in

Signed-off-by: Anton Gilgur <agilgur5@gmail.com>
@agilgur5 agilgur5 added type/dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels Jan 6, 2024
@terrytangyuan terrytangyuan merged commit 9933a5d into argoproj:master Feb 5, 2024
5 checks passed
@agilgur5 agilgur5 deleted the chore-deps-remove-unused-v2-yarn-lock branch February 5, 2024 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
javascript Pull requests that update Javascript code type/dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants