Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

REQUEST: Promotion to Approver for @agilgur5 #277

Closed
4 of 7 tasks
agilgur5 opened this issue Feb 1, 2024 · 5 comments · Fixed by #280
Closed
4 of 7 tasks

REQUEST: Promotion to Approver for @agilgur5 #277

agilgur5 opened this issue Feb 1, 2024 · 5 comments · Fixed by #280
Labels
type/promotion-request Request for Promotion in a subproject

Comments

@agilgur5
Copy link
Member

agilgur5 commented Feb 1, 2024 •
edited
Loading

Follow-up to #242
Sorry that I filed this the night before the membership meeting (although I did bring it up unofficially earlier), I've been, er, a bit preoccupied in passing a kidney stone the past week and all the pre-, side-, and after-effects of that and the (hard) medications 🫠
Also sorry if it's not as organized as my previous ones, because boy did those medications hit my brain like a truck 😵‍💫

GitHub Username

@agilgur5

Sub-project(s)

Promotion is requested for the following sub-project(s).

  • Argo CD
  • Argo Events
  • Argo Rollouts
  • Argo Workflows

Other repos

  • argo-ui

Also argo-site and pkg could be useful, but I have significantly more contributions to argo-ui than either of those.

Requirements

  • Reviewer for at least 3 months (as of the membership meeting date)
  • Reviewer for or author of at least 10 substantial PRs to the codebase

In my Reviewer promotion request in #242, I already had substantially more than the requirements for Approver, so here I'll just list some more from the past ~3 months of being a Reviewer. My Reviewer promotion also had a ton of support and praise.

Selected Code Reviews

Noting here that Julie wrote in my Reviewer promotion request that I may well be the most thorough code reviewer on Workflows 🙂 ❤️

Selected PRs

I'm also currently juggling like 20+ open PRs as well and still have some branches WIP as well; it's a lot to keep organized 😅

New Total

  • 135+ PRs opened
  • 340+ PRs responded to and/or reviewed
  • See issues, discussions, etc stats below in "Other"

Familiarity

  • Largely same as before, but now I know the Controller and the E2E test suites a bit better as I've had a few more reviews and contributions there
    • I have been intentionally spending some more time doing bugfixes in those to increase my familiarity, but it's vast enough that I would not yet call myself an expert in those and will still rely on others to double-check my reviews in places that I'm unfamiliar and not confident in my review (in general, I do not approve PRs that I do not feel confident in my understanding of).
    • Currently, I believe I am the top expert on the Docs, UI, and all build systems, and potentially parts of the Server and CLI as well (and maybe some of the informers in the Controller as well).

Other contributions and stats

  • Main changes to CNCF DevStats for Argo Workflows is that I am now top 3 contributors in the past 2 years and top 1 in the past 6 months - 3 months - 1 month

    • Here's updated screenshots at 2 years and at 6 months (I am in pale yellow):
      Screenshot 2024-01-31 at 10 37 10 PM
      Screenshot 2024-01-31 at 10 37 43 PM
    • Similar to before, for the 2 year range I have achieved that despite only actively contributing the past ~6 months, i.e. in a much smaller time period than the width of the range, the entirety of which the average is taken from.

  • Responded to hundreds of users over issues (300+), discussions (100+ + many sub-discussions in giscus), and Slack

    • Still very active in all our Slack channels, particularly in user support in #argo-workflows, where I probably have several hundred responses if I could do a COUNT on it.
      • When I had some family and personal medical emergencies to attend to (for weeks; lot of hospitalizations in the fam recently 😞), I could not contribute as much code or reviews (see the dip in the graph above), but I was still quite active in those channels that don't require the same large blocks of focus time as coding or reviewing code

  • Encouraged more contributors to request membership, see REQUEST: New membership for @Garett-MacGowan #269 in this repo 🙌 🙂

  • Continued to handle Bug Triage on my own whenever I check on the issues and still handle the vast majority of issue triage

    • Alan has started helping too recently

  • Admin of the FOSSA license scan where I set things up and diligently checked & documented all false positives etc

  • Admin of the new ReadTheDocs site

Lead Sponsor(s)

Promotion to Approver requires sponsorship from at least one sub-project Lead.

Other Sponsors

Will add some more sponsors once this issue is filed
@Joibel
Copy link
Member

Joibel commented Feb 1, 2024

+1 for Anton, he's doing amazing work on the project.

@isubasinghe
Copy link
Member

+1 for Anton as well

@sarabala1979
Copy link
Member

+1 for Anton.

@terrytangyuan
Copy link
Member

+1

1 similar comment
@Garett-MacGowan
Copy link

+1

@crenshaw-dev crenshaw-dev mentioned this issue Feb 5, 2024
Merged
This was referenced Feb 5, 2024
Open
Closed
@agilgur5 agilgur5 mentioned this issue Feb 29, 2024
Merged
9 tasks
@agilgur5 agilgur5 mentioned this issue Apr 5, 2024
Open
@agilgur5 agilgur5 added the type/promotion-request Request for Promotion in a subproject label Apr 9, 2024
@agilgur5 agilgur5 mentioned this issue May 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/promotion-request Request for Promotion in a subproject
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Argoproj promotions/membership crenshaw-dev/argoproj
6 participants
@Joibel @terrytangyuan @agilgur5 @Garett-MacGowan @isubasinghe @sarabala1979