Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: correct typing errors in several components and dependencies #71

Merged
merged 7 commits into from
Nov 5, 2020

Conversation

dcherman
Copy link
Member

@dcherman dcherman commented Nov 5, 2020

This is intended to be an easily reviewable subset of the changes proposed in #68

Signed-off-by: Daniel Herman <dherman@factset.com>
Signed-off-by: Daniel Herman <dherman@factset.com>
Signed-off-by: Daniel Herman <dherman@factset.com>
Signed-off-by: Daniel Herman <dherman@factset.com>
the current version of webpack-dev-server depends on a bad version
of @types/node that causes problems for typescript users.  there
is not a newer version available right now, so we can override
the version being loaded until v4 has been released

Signed-off-by: Daniel Herman <dherman@factset.com>
Signed-off-by: Daniel Herman <dherman@factset.com>
Signed-off-by: Daniel Herman <dherman@factset.com>
Copy link
Contributor

@alexec alexec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexec alexec merged commit 546911a into argoproj:master Nov 5, 2020
@agilgur5 agilgur5 added type/dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels Jan 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
javascript Pull requests that update Javascript code type/dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants