Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): remove unused deps & resolutions #534

Merged

Conversation

agilgur5
Copy link
Member

@agilgur5 agilgur5 commented Feb 12, 2024

Originally started as a follow-up to argoproj/argo-workflows#12097 (comment) on moment-timezone, but there were actually much more unused deps to prune

Motivation

Deps

  • these are all completely unused in the current codebase (search codebase, no references)
    • maybe some of these were used at some point in the past, but none of them are currently used

resolutions

Modifications

  • remove unused moment-timezone from dependencies
  • remove several unused devDependencies
  • remove a few unnecessary or unused Yarn resolutions

Verification

  • installs, builds, tests, etc still work without all these

Notes to Reviewers

I actually wrote this on Jan 6th (see the commits), the same time as my other PRs, but I thought this would merge conflict with some of them, so I didn't create the PR, intending to rebase with those once they were merged. This actually seems to not conflict with #511 at all as far as I can tell, so creating the PR now, and because it's already been over a month with no review/merge 馃槙 EDIT: Welp, they actually conflicted with #509. I have a feeling past me predicted that and then I just forgot over the past month

@agilgur5 agilgur5 added type/dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels Feb 12, 2024
@agilgur5 agilgur5 force-pushed the chore-deps-remove-unused-moment-tz branch from 9bc0e3c to 4008bc4 Compare February 13, 2024 15:49
@agilgur5
Copy link
Member Author

Fixed merge conflicts with #509.

There's a new warning during the install that seems to be because dependabot just merged #539 and #541 (they were created before #537 was merged), which are almost certainly not compatible 馃槙 . They seem to have finally passed CI because #509 removed some old deps. That does bolster the case of #537

@agilgur5
Copy link
Member Author

lint is weirdly erroring here but not in other PRs that similarly don't change source code... strange...

Raised #543 for that since it's independent of this PR. Will have to rebase once that's merged

This comment was marked as resolved.

@github-actions github-actions bot added the problem/stale This has not had a response in some time label Apr 15, 2024
@agilgur5 agilgur5 removed the problem/stale This has not had a response in some time label Apr 15, 2024
@agilgur5 agilgur5 force-pushed the chore-deps-remove-unused-moment-tz branch from eb71bea to f508f47 Compare May 11, 2024 23:29
@agilgur5
Copy link
Member Author

agilgur5 commented May 11, 2024

lint is weirdly erroring here but not in other PRs that similarly don't change source code... strange...

Raised #543 for that since it's independent of this PR. Will have to rebase once that's merged

I may have figured out why that's happening, some of the ESLint deps ended up getting upgraded a few minors in the yarn.lock in this PR. Let me fix that

Perhaps may have been due to a bad merge conflict resolution with #509

- these are all completely unused in the current codebase (search codebase, no references)
  - installs, builds, tests, etc still work without all these
  - maybe some of these were used at some point in the past, but none of them are currently used

Signed-off-by: Anton Gilgur <agilgur5@gmail.com>
- `lodash` resolution is no longer needed as all deps are compatible with `lodash` `^4`
  - 640ede9 added it and it _may_ have been necessary for some of the `lodash` v3 deps there, but this codebase no longer has any `lodash` v3 deps

- `@types/history` is already using `^4.7.8` without the resolution
  - 546911a added it while also upgrading the devDep; only upgrading the devDep was necessary

Signed-off-by: Anton Gilgur <agilgur5@gmail.com>
@crenshaw-dev crenshaw-dev merged commit d1bd03e into argoproj:master May 12, 2024
5 checks passed
@agilgur5 agilgur5 deleted the chore-deps-remove-unused-moment-tz branch May 12, 2024 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
javascript Pull requests that update Javascript code type/dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants