-
Notifications
You must be signed in to change notification settings - Fork 3.2k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat(controller): Use different container runtime executors for each …
- Loading branch information
Showing
16 changed files
with
496 additions
and
257 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,36 @@ | ||
| package config | ||
|
|
||
| import ( | ||
| metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" | ||
| "k8s.io/apimachinery/pkg/labels" | ||
| ) | ||
|
|
||
| type ContainerRuntimeExecutors []ContainerRuntimeExecutor | ||
|
|
||
| // select the correct executor to use | ||
| // this may return an empty string of there is not executor found | ||
| func (e ContainerRuntimeExecutors) Select(labels labels.Labels) (string, error) { | ||
| for _, c := range e { | ||
| ok, err := c.Matches(labels) | ||
| if err != nil { | ||
| return "", err | ||
| } | ||
| if ok { | ||
| return c.Name, nil | ||
| } | ||
| } | ||
| return "", nil | ||
| } | ||
|
|
||
| type ContainerRuntimeExecutor struct { | ||
| Name string `json:"name"` | ||
| Selector metav1.LabelSelector `json:"selector"` | ||
| } | ||
|
|
||
| func (e ContainerRuntimeExecutor) Matches(labels labels.Labels) (bool, error) { | ||
| x, err := metav1.LabelSelectorAsSelector(&e.Selector) | ||
| if err != nil { | ||
| return false, err | ||
| } | ||
| return x.Matches(labels), nil | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,43 @@ | ||
| package config | ||
|
|
||
| import ( | ||
| "testing" | ||
|
|
||
| "github.com/stretchr/testify/assert" | ||
| metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" | ||
| "k8s.io/apimachinery/pkg/labels" | ||
| ) | ||
|
|
||
| func TestContainerRuntimeExecutors(t *testing.T) { | ||
| t.Run("Empty", func(t *testing.T) { | ||
| x := ContainerRuntimeExecutors{} | ||
| e, err := x.Select(labels.Set{}) | ||
| assert.NoError(t, err) | ||
| assert.Empty(t, e) | ||
| }) | ||
| t.Run("Select", func(t *testing.T) { | ||
| x := ContainerRuntimeExecutors{ | ||
| { | ||
| Name: "foo", | ||
| Selector: metav1.LabelSelector{ | ||
| MatchLabels: map[string]string{"bar": ""}, | ||
| }, | ||
| }, | ||
| } | ||
| e, err := x.Select(labels.Set(map[string]string{"bar": ""})) | ||
| assert.NoError(t, err) | ||
| assert.Equal(t, "foo", e) | ||
| }) | ||
| t.Run("Error", func(t *testing.T) { | ||
| x := ContainerRuntimeExecutors{ | ||
| { | ||
| Name: "foo", | ||
| Selector: metav1.LabelSelector{ | ||
| MatchLabels: map[string]string{"!": "!"}, | ||
| }, | ||
| }, | ||
| } | ||
| _, err := x.Select(labels.Set(map[string]string{"bar": ""})) | ||
| assert.Error(t, err) | ||
| }) | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.