fix: artifactory not working. Fixes #9681 (#9782)

* fix: artifactory not working. Fixes #9681

Signed-off-by: Alexander Dittmann <alexander.dittmann@sap.com>

* fix: make pre-commit -B

Signed-off-by: Alex Collins <alex_collins@intuit.com>

Signed-off-by: Alexander Dittmann <alexander.dittmann@sap.com>
Signed-off-by: Alex Collins <alex_collins@intuit.com>
Co-authored-by: Alex Collins <alex_collins@intuit.com>

test/e2e/http_artifacts_test.go

@@ -55,6 +55,14 @@ func (s *HttpArtifactsSuite) TestClientCertAuthArtifactHttp() {
 		WaitForWorkflow(fixtures.ToBeSucceeded)
 }
 
+func (s *HttpArtifactsSuite) TestArtifactoryArtifacts() {
+	s.Given().
+		Workflow("@testdata/http/artifactory-artifact.yaml").
+		When().
+		SubmitWorkflow().
+		WaitForWorkflow(fixtures.ToBeSucceeded)
+}
+
 func TestHttpArtifactsSuite(t *testing.T) {
 	suite.Run(t, new(HttpArtifactsSuite))
 }

test/e2e/testdata/http/artifactory-artifact.yaml

@@ -0,0 +1,35 @@
+apiVersion: argoproj.io/v1alpha1
+kind: Workflow
+metadata:
+  generateName: artifactory-artifact-http-
+spec:
+  entrypoint: main
+  templates:
+  - name: main
+    inputs:
+      artifacts:
+      - name: my-art
+        path: /my-artifact
+        artifactory:
+          url: http://httpbin:9100/basic-auth/admin/password
+          usernameSecret:
+            name: my-httpbin-cred
+            key: user
+          passwordSecret:
+            name: my-httpbin-cred
+            key: pass
+    outputs:
+      artifacts:
+      - name: my-art
+        path: /my-artifact
+        artifactory:
+          url: http://httpbin:9100/put
+          usernameSecret:
+            name: my-httpbin-cred
+            key: user
+          passwordSecret:
+            name: my-httpbin-cred
+            key: pass
+    container:
+      image: argoproj/argosay:v2
+      command: [cat, "/my-artifact"]

workflow/artifacts/artifacts.go

@@ -181,6 +181,7 @@ func newDriver(ctx context.Context, art *wfv1.Artifact, ri resource.Interface) (
 		driver := http.ArtifactDriver{
 			Username: usernameBytes,
 			Password: passwordBytes,
+			Client:   &gohttp.Client{},
 		}
 		return &driver, nil