fix: artifactory not working. Fixes #9681 #9782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexander Dittmann <alexander.dittmann@sap.com>
alexdittmann
force-pushed
the
fix-artifactory
branch
from
904562b
to
f0d0530
Compare
Signed-off-by: Alex Collins <alex_collins@intuit.com>
alexec
approved these changes
Oct 10, 2022
juchaosong
pushed a commit
to juchaosong/argo-workflows
that referenced
this pull request
Nov 3, 2022
* fix: artifactory not working. Fixes argoproj#9681 Signed-off-by: Alexander Dittmann <alexander.dittmann@sap.com> * fix: make pre-commit -B Signed-off-by: Alex Collins <alex_collins@intuit.com> Signed-off-by: Alexander Dittmann <alexander.dittmann@sap.com> Signed-off-by: Alex Collins <alex_collins@intuit.com> Co-authored-by: Alex Collins <alex_collins@intuit.com> Signed-off-by: juchao <juchao@coscene.io>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Alexander Dittmann alexander.dittmann@sap.com
Fixes #9681
The problem was that the http client was not initialized in for the artifactory artifact type in artifacts.go
I added an additional e2e test for the artifatory artifact which uses the same HTTP infrastructure as the other HTTP tests.