Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I want to contribute to issue 11387, I need help from a mentor. #11402

Closed
Jack-R-lantern opened this issue Jul 20, 2023 · 5 comments
Closed

I want to contribute to issue 11387, I need help from a mentor. #11402

Jack-R-lantern opened this issue Jul 20, 2023 · 5 comments

Comments

@Jack-R-lantern
Copy link
Contributor

Question: Have you read the mentoring guide? Please only submit this request for general mentoring (not GSoC).

Answer: Yes I have read the mentoring guide.

What is your background? Any experience with Go, Kubernetes, React, Typescript, etc.?

Answer: I have previous experience in Go, Kubernetes

Is there any particular issue you'd like to work on? You may want to check out the list of good first issues.

Answer: **I would like to work with issue #11387 **

Do you want to work with your mentor async (i.e. by Slack messaging or issue comments), or sync (e.g. using Zoom video)? Please include your time-zone if you want to work sync.

Answer: async. and my time-zone is KST


I apologize for the hasty PR I submitted.
I'm a newbie contributor.
I'm interested in the issue and would like to address it. Please help me

@terrytangyuan
Copy link
Member

@juliev0 Perhaps you could provide some guidance on how you were planning to approach #11387 and see if @Jack-R-lantern can pick it up?

@juliev0
Copy link
Contributor

juliev0 commented Jul 20, 2023

Sure. So, just to give more information - what we are seeing is not that an error is returned when there's client-side throttling. Rather it's just that the call being made here is blocked for awhile. What I was thinking was that we could put a timer around that call and if it's over some threshold then log a warning.

@Jack-R-lantern
Copy link
Contributor Author

@juliev0 @terrytangyuan
Thanks for the advice.
I will proceed based on your advice.

@Jack-R-lantern
Copy link
Contributor Author

@juliev0
Should there be a separate threshold criterion?

@juliev0
Copy link
Contributor

juliev0 commented Jul 21, 2023

@juliev0 Should there be a separate threshold criterion?

Do you mean, should it be a configurable thing? I thought about that but probably not needed. How about if the time takes more than 5 seconds we log a warning maybe? And definitely include the amount of time in the warning message.

A separate follow up to this could be to add a metric counter for slow messages or something - for that I could see there might be a desire for configurability.

Jack-R-lantern added a commit to Jack-R-lantern/argo-workflows that referenced this issue Jul 22, 2023
Implemented logging of throttling.
when a delay of more than 5 seconds occurs.

Fixes: argoproj#11387 argoproj#11402

Signed-off-by: Jack-R-lantern <tjdfkr2421@gmail.com>
Jack-R-lantern added a commit to Jack-R-lantern/argo-workflows that referenced this issue Jul 22, 2023
Implemented logging of throttling.
when a delay of more than 5 seconds occurs.

Fixes: argoproj#11387 argoproj#11402

Signed-off-by: Jack-R-lantern <tjdfkr2421@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants