feat: logging for client-side throttling #11437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implemented logging of throttling. when a delay of more than 5 seconds occurs. Signed-off-by: Jack-R-lantern <tjdfkr2421@gmail.com>
Jack-R-lantern
force-pushed
the
ISSUE-11387/Better-exposure-for-client-side-throttling
branch
from
2863fb2
to
df5b06b
Compare
|
client-go implemented extraLongThrottleLatency as 1 second. |
juliev0
approved these changes
Jul 25, 2023
terrytangyuan
approved these changes
Jul 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented logging of throttling.
when a delay of more than 5 seconds occurs.
Fixes #11387 #11402
Motivation
To make it faster for users to notice when client-side throttling is happening.
Modifications
Implemented to output a warning if latency is greater than 5 seconds when qps, burst is set very low
Verification