fix: set daemon pod failed when exit with a non-zero status. Fixes:#12911 #12988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shuangkun
force-pushed
the
fix/DaemonPod
branch
2 times, most recently
from
2ac9757
to
1724e0b
Compare
shuangkun
force-pushed
the
fix/DaemonPod
branch
3 times, most recently
from
91f43b6
to
7dd8b0e
Compare
|
/retest |
…j#12911 Signed-off-by: shuangkun <tsk2013uestc@163.com>
Signed-off-by: shuangkun <tsk2013uestc@163.com>
juliev0
reviewed
May 10, 2024
| WithField("pod", pod.Name).Infof("Pod failed: %s", new.Message) | ||
| } | ||
| new.Phase, new.Message = woc.inferFailedReason(pod, tmpl) | ||
| woc.log.WithField("displayName", old.DisplayName).WithField("templateName", old.TemplateName).WithField("pod", pod.Name).Infof("Pod failed: %s", new.Message) |
There was a problem hiding this comment.
It seems like somebody explicitly thought that Daemons should never been in a Failed state. Do we understand why?
|
It appears that this was by design that the Workflow and Node should succeed even if the Daemon failed. I wonder if it should be configurable in the ConfigMap and/or Workflow if perhaps some users want the opposite? |
4 tasks
Yes I can try that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12911
Motivation
set daemon pod failed when exit with a non-zero status
Modifications
Verification