Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backoff exponent is off by one #3513

Closed
3 of 4 tasks
jiezhang opened this issue Jul 18, 2020 · 1 comment · Fixed by #3514
Closed
3 of 4 tasks

Backoff exponent is off by one #3513

jiezhang opened this issue Jul 18, 2020 · 1 comment · Fixed by #3514
Labels

Comments

@jiezhang
Copy link
Contributor

jiezhang commented Jul 18, 2020

Checklist:

  • I've included the version.
  • I've included reproduction steps.
  • I've included the workflow YAML.
  • I've included the logs.

What happened:
Given the retry strategy below, the first retry attempt backs off 10 minutes.

     retryStrategy:
       limit: 2
       retryPolicy: "Always"
       backoff: 
         duration: "5m"
         factor: 2

What you expected to happen:
The first retry attempt should backoff 5 minutes and the second one backoff 10 minutes.

As far as I know, most retry libraries use the duration as the initial duration. For example, the backoff package used by apiserver (ref) is implemented this way (ref).

How to reproduce it (as minimally and precisely as possible):

  1. Delete the pod while the workflow is running.
  2. The backoff message is displayed in the UI: Retrying in 9 minutes 59 seconds.

Anything else we need to know?:

Environment:

  • Argo version: v2.7.5 (but it should reproduce in master too)

Message from the maintainers:

If you are impacted by this bug please add a 👍 reaction to this issue! We often sort issues this way to know what to prioritize.

@alexec
Copy link
Contributor

alexec commented Sep 2, 2020

Available for testing in v2.11.0-rc1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants