Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(controller): Backoff exponent is off by one. Fixes #3513 #3514

Merged
merged 2 commits into from Jul 21, 2020
Merged

fix(controller): Backoff exponent is off by one. Fixes #3513 #3514

merged 2 commits into from Jul 21, 2020

Conversation

jiezhang
Copy link
Contributor

@jiezhang jiezhang commented Jul 18, 2020 •
edited

This PR changes the backoff exponent to start from zero. See #3513 for details.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed the CLA.
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

@jiezhang
Copy link
Contributor Author

/assign @alexec @simster7

@alexec alexec linked an issue Jul 18, 2020 that may be closed by this pull request
Backoff exponent is off by one #3513
Closed
4 tasks
@simster7 simster7 self-assigned this Jul 20, 2020
@simster7 simster7 merged commit b901b27 into argoproj:master Jul 21, 2020
@jiezhang
Copy link
Contributor Author

@simster7 Thank you!

alexec pushed a commit that referenced this pull request Jul 28, 2020
@jiezhang @alexec
fix(controller): Backoff exponent is off by one. Fixes #3513 (#3514)
32c36d7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simster7 simster7 simster7 approved these changes

Assignees

@simster7 simster7

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Backoff exponent is off by one
2 participants
@jiezhang @simster7