Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide enum type parameters for Argo workflows #4192

Closed
basanthjenuhb opened this issue Oct 2, 2020 · 3 comments
Closed

Provide enum type parameters for Argo workflows #4192

basanthjenuhb opened this issue Oct 2, 2020 · 3 comments
Labels
area/spec Changes to the workflow specification. type/feature Feature request

Comments

@basanthjenuhb
Copy link
Contributor

basanthjenuhb commented Oct 2, 2020

Summary

This is an enhancement to provide choice parameters as provided by Jenkins
Jenkins Example:

choice(name: 'CHOICE', choices: ['One', 'Two', 'Three'], description: 'Pick something')

A similar input parameter type could be provided for workflows. Something in the lines of

arguments:
    parameters:
    - name: choice
      defaultValue: one
      valueFrom:
           choices:
               - one
               - two
               - three

Use Cases

When would you use this?

Anyone who is submitting a workflow template from UI, would be able to specify arguments from the dropdown which has values from the choices array


Message from the maintainers:

Impacted by this bug? Give it a 👍. We prioritise the issues with the most 👍.

@basanthjenuhb basanthjenuhb added the type/feature Feature request label Oct 2, 2020
@alexec
Copy link
Contributor

alexec commented Oct 2, 2020

@jessesuen @basanthjenuhb want to work on this as part of hacktoberfest. I think we need to come up with a suitable way to specify the options, I'd lean more towards:

arguments:
    parameters:
    - name: choice
      defaultValue: one
      enum:
               - one
               - two
               - three

@basanthjenuhb
Copy link
Contributor Author

Making the changes in #4314
UI PR coming up next

@basanthjenuhb
Copy link
Contributor Author

Making the UI changes in #4365
@alexec can you help with the PR

@alexec alexec reopened this Oct 26, 2020
@alexec alexec closed this as completed in 5614700 Dec 7, 2020
@agilgur5 agilgur5 added the area/spec Changes to the workflow specification. label Sep 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/spec Changes to the workflow specification. type/feature Feature request
Projects
None yet
Development

No branches or pull requests

3 participants