Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(controller): add enum support in parameters (fixes #4192) #4314

Merged
merged 10 commits into from
Oct 20, 2020
Merged

feat(controller): add enum support in parameters (fixes #4192) #4314

merged 10 commits into from
Oct 20, 2020

Conversation

basanthjenuhb
Copy link
Contributor

@basanthjenuhb basanthjenuhb commented Oct 17, 2020 •
edited
Loading

Enhancement proposal - #4192
UI PR coming up next

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • My organization is added to USERS.md.
  • I've signed the CLA.
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.

@basanthjenuhb basanthjenuhb changed the title fix: add enum support in parameters fix: add enum support in parameters (fixex #4192) Oct 17, 2020
@basanthjenuhb basanthjenuhb changed the title fix: add enum support in parameters (fixex #4192) fix: add enum support in parameters (fixes #4192) Oct 17, 2020
@basanthjenuhb basanthjenuhb mentioned this pull request Oct 17, 2020
Closed
@basanthjenuhb basanthjenuhb changed the title fix: add enum support in parameters (fixes #4192) fix: add enum support in parameters (fixes https://github.com/argoproj/argo/issues/4192) Oct 17, 2020
@basanthjenuhb basanthjenuhb changed the title fix: add enum support in parameters (fixes https://github.com/argoproj/argo/issues/4192) fix: add enum support in parameters (fixes #4192) Oct 17, 2020
@basanthjenuhb
Copy link
Contributor Author

@alexec The Codegen (pull_request) is complaining about differences in

  • api/openapi-spec/swagger.json
  • docs/fields.md
  • openapi_generated.go
  • test/e2e/workflow_template_test.go

I haven't make changes in first 3.
And have added test in 4th.
How can I fix issues of codegen
Thanks

@basanthjenuhb
Copy link
Contributor Author

@alexec Have fixed issues, please let me know if any changes are required

@alexec
Copy link
Contributor

alexec commented Oct 17, 2020

How can I fix issues of codegen

make codegen

@basanthjenuhb
Copy link
Contributor Author

Thanks @alexec , the codegen issues are fixed and build is green,
How can we take this PR forward

alexec
alexec reviewed Oct 18, 2020
View reviewed changes
Copy link
Contributor

@alexec alexec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look good. Need @jessesuen to approve photo change. Would be good to support this in the UI at some point.

@basanthjenuhb
Copy link
Contributor Author

@alexec I'll raise a UI PR after this gets merged. I actually have changes ready

@alexec alexec changed the title fix: add enum support in parameters (fixes #4192) feat(controller): add enum support in parameters (fixes #4192) Oct 19, 2020
alexec
alexec reviewed Oct 19, 2020
View reviewed changes
test/e2e/workflow_template_test.go
WaitForWorkflow().
Then().
ExpectWorkflow(func(t *testing.T, metadata *v1.ObjectMeta, status *v1alpha1.WorkflowStatus) {
assert.Equal(t, status.Phase, v1alpha1.NodeSucceeded)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't we want to test failure here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, workflow-template-with-enum-values.yaml contains a valid workflow
It should not result in an error

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alexec Should I add a separate failing test

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think if you can cover it with unit tests - we do not need an e2e test.

jessesuen
jessesuen approved these changes Oct 20, 2020
View reviewed changes
Copy link
Member

@jessesuen jessesuen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approval of type changes

@alexec alexec merged commit 939d8c3 into argoproj:master Oct 20, 2020
@alexec alexec added this to the v2.12 milestone Oct 20, 2020
@basanthjenuhb
Copy link
Contributor Author

@alexec Thanks for merging. Will let you know when the UI PR is ready

@agilgur5 agilgur5 mentioned this pull request Sep 8, 2023
Closed
6 tasks
@agilgur5 agilgur5 added the area/spec Changes to the workflow specification. label Sep 8, 2023
@agilgur5 agilgur5 mentioned this pull request Jan 26, 2024
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexec alexec alexec left review comments

@jessesuen jessesuen jessesuen approved these changes

Assignees

@jessesuen jessesuen

Labels
area/spec Changes to the workflow specification.
Projects
None yet
Milestone
v2.12
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@basanthjenuhb @alexec @jessesuen @agilgur5