Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): Add parameter value enum support to the UI. Fixes #4192 #4365

Merged
merged 9 commits into from Dec 7, 2020
Merged

feat(ui): Add parameter value enum support to the UI. Fixes #4192 #4365

merged 9 commits into from Dec 7, 2020

Conversation

basanthjenuhb
Copy link
Contributor

@basanthjenuhb basanthjenuhb commented Oct 24, 2020

Feature: Add UI support for enums
Discussed in #4192

Signed-off-by: basanthjenuhb basanthjenuhb@gmail.com

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • My organization is added to USERS.md.
  • I've signed the CLA.
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.

Signed-off-by: basanthjenuhb <basanthjenuhb@gmail.com>
@basanthjenuhb basanthjenuhb changed the title fix(ui): add enum support in UI fix(ui): add enum support in UI (fixes #4192) Oct 24, 2020
@basanthjenuhb basanthjenuhb marked this pull request as draft October 24, 2020 01:57
Signed-off-by: basanthjenuhb <basanthjenuhb@gmail.com>
@alexec
Copy link
Contributor

alexec commented Oct 26, 2020

@basanthjenuhb looks good from source code. Can you please add a screenshot?

@alexec alexec changed the title fix(ui): add enum support in UI (fixes #4192) fix(ui): add enum support in UI. Fixes #4192 Oct 27, 2020
@alexec alexec changed the title fix(ui): add enum support in UI. Fixes #4192 feat(ui): Add parameter value enum support to the UI. Fixes #4192 Oct 27, 2020
@alexec
Copy link
Contributor

alexec commented Dec 1, 2020

@basanthjenuhb - do you plan to continue working on this, please?

@alexec
Copy link
Contributor

alexec commented Dec 1, 2020

Slacked @basanthjenuhb asking if he plans to finish this.

@basanthjenuhb
Copy link
Contributor Author

yes, @alexec , finishing it today

@basanthjenuhb
Copy link
Contributor Author

@alexec build failing in e2e tests
stat: cannot stat '/etc/rancher/k3s/k3s.yaml': No such file or directory
can you please help in fixing this

@basanthjenuhb
Copy link
Contributor Author

Screenshot 2020-12-05 at 8 56 17 AM

Screenshot 2020-12-05 at 8 56 27 AM

Choosing two in the dropdown

Screenshot 2020-12-05 at 8 56 42 AM

@alexec Added screenshots

@basanthjenuhb basanthjenuhb marked this pull request as ready for review December 5, 2020 03:31
Signed-off-by: basanthjenuhb <basanthjenuhb@gmail.com>
@basanthjenuhb
Copy link
Contributor Author

@alexec Builds are green again, we can go ahead with this pr

@alexec alexec self-assigned this Dec 7, 2020
@alexec alexec merged commit 5614700 into argoproj:master Dec 7, 2020
@agilgur5 agilgur5 mentioned this pull request Sep 8, 2023
6 tasks
@agilgur5 agilgur5 mentioned this pull request Sep 8, 2023
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants