Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow grace before marking nodes as error + "pod deleted" #4719

Closed
alexec opened this issue Dec 11, 2020 · 0 comments · Fixed by #4725 or #4742
Closed

Allow grace before marking nodes as error + "pod deleted" #4719

alexec opened this issue Dec 11, 2020 · 0 comments · Fixed by #4725 or #4742
Labels
type/bug

Comments

@alexec
Copy link
Contributor

alexec commented Dec 11, 2020 •
edited

We don't always seem to get updates about pods when K8S is under high load. Allow a grace period before failing workflows.

Add a Prometheus metric too.
@alexec alexec mentioned this issue Dec 11, 2020
Closed
alexec added a commit to alexec/argo-workflows that referenced this issue Dec 11, 2020
@alexec
feat(controller): Pod deletion grace period. Fixes argoproj#4719
aaab66c 
Signed-off-by: Alex Collins <alex_collins@intuit.com>
@alexec alexec mentioned this issue Dec 11, 2020
Merged
1 task
alexec added a commit that referenced this issue Dec 14, 2020
@alexec
feat(controller): Pod deletion grace period. Fixes #4719 (#4725)
724fd80 
Signed-off-by: Alex Collins <alex_collins@intuit.com>
@simster7 simster7 mentioned this issue Dec 15, 2020
Closed
22 tasks
@alexec alexec mentioned this issue Dec 15, 2020
Merged
1 task
alexec added a commit that referenced this issue Dec 15, 2020
@alexec
fix(controller): Requeue when the pod was deleted. Fixes #4719 (#4742)
300db5e 
Signed-off-by: Alex Collins <alex_collins@intuit.com>
@simster7 simster7 mentioned this issue Dec 17, 2020
Closed
9 tasks
alexec added a commit that referenced this issue Dec 18, 2020
@alexec
feat(controller): Pod deletion grace period. Fixes #4719 (#4725)
11bc9c4 
Signed-off-by: Alex Collins <alex_collins@intuit.com>
alexec added a commit that referenced this issue Dec 18, 2020
@alexec
fix(controller): Requeue when the pod was deleted. Fixes #4719 (#4742)
e8c4aa4 
Signed-off-by: Alex Collins <alex_collins@intuit.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/bug
Projects
None yet
Milestone
No milestone
1 participant
@alexec