Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(controller): Requeue when the pod was deleted. Fixes #4719 #4742

Merged
merged 2 commits into from Dec 15, 2020

Conversation

alexec
Copy link
Contributor

@alexec alexec commented Dec 15, 2020

Signed-off-by: Alex Collins alex_collins@intuit.com
Fixes #4719

Checklist:

Signed-off-by: Alex Collins <alex_collins@intuit.com>
@alexec alexec marked this pull request as ready for review December 15, 2020 01:26
@alexec
Copy link
Contributor Author

alexec commented Dec 15, 2020

@sarabala1979 my change introduced a flakiness bug.

@alexec alexec changed the title fix(controller): Requeue when the pod was deleted. fix(controller): Requeue when the pod was deleted. Fixes #4719 Dec 15, 2020
@alexec alexec merged commit 300db5e into argoproj:master Dec 15, 2020
@alexec alexec deleted the requeue branch December 15, 2020 17:07
@simster7 simster7 mentioned this pull request Dec 17, 2020
9 tasks
alexec added a commit that referenced this pull request Dec 18, 2020
Signed-off-by: Alex Collins <alex_collins@intuit.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow grace before marking nodes as error + "pod deleted"
2 participants