Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

'heebo.css' requests always return html root #4730

Closed
hughobrien opened this issue Dec 12, 2020 · 1 comment · Fixed by #4739
Closed

'heebo.css' requests always return html root #4730

hughobrien opened this issue Dec 12, 2020 · 1 comment · Fixed by #4739
Assignees
@alexec
Labels
type/bug

Comments

@hughobrien
Copy link

hughobrien commented Dec 12, 2020 •
edited

Summary

According to the browser network logs, requests to assets/styles/heebo.css are invalid. Accessing the resource directly shows that the index html is returned instead of any css. A base_href envvar is in use, but it seems reproducible without it.
This is a namespaced install.

Other resource seem simarly affected, from the browser console log:

Refused to apply style from 'https://<snip>/infra/argo/assets/styles/heebo.css' because its MIME type ('text/html') is not a supported stylesheet MIME type, and strict MIME checking is enabled.

DevTools failed to load SourceMap: Could not parse content for https://<snip>/infra/argo/ReactToastify.css.map: Unexpected token < in JSON at position 0

DevTools failed to load SourceMap: Could not parse content for https://<snip>/infra/argo/swagger-ui.css.map: Unexpected token < in JSON at position 0

Diagnostics

What Kubernetes provider are you using?

AKS

What version of Argo Workflows are you running?

2.11.8

hugh@dev:~$ k get deployment -n argo argo-server -o yaml | grep image:
        image: argoproj/argocli@sha256:9a268191b1a877004bef3d47a8bf9527af78e03fea1b872afd55ce3fda82fae6
hugh@dev:~$ kubectl get pods --field-selector=status.phase=Running -n argo -o wide
NAME                                  READY   STATUS    RESTARTS   AGE     IP            NODE                           NOMINATED NODE   READINESS GATES
argo-server-fcb4cd55c-vzghg           1/1     Running   0          9m19s   10.100.0.50   aks-main-26567389-vmss000001   <none>           <none>
minio-7d94dd75db-95n7g                1/1     Running   0          14d     10.100.0.31   aks-main-26567389-vmss000000   <none>           <none>
workflow-controller-d6479fd97-jrltb   1/1     Running   0          9m18s   10.100.0.42   aks-main-26567389-vmss000001   <none>           <none>
hugh@dev:~$ kubectl run --rm -it -n argo --image=alpine:3.12 shell -- sh
If you don\'t see a command prompt, try pressing enter.
/ # apk add curl
<snip>
OK: 7 MiB in 18 packages
/ # curl 10.100.0.50:2746
<!DOCTYPE html>
<html lang="en">

<head>
    <meta charset="UTF-8">
    <title>Argo</title>
    <base href="/infra/argo/">
    <link href="assets/styles/heebo.css" rel="stylesheet">
    <meta name="viewport" content="width=device-width, initial-scale=1">
    <meta name="robots" content="noindex">
    <link rel="icon" type="image/png" href="assets/favicon/favicon-32x32.png" sizes="32x32">
    <link rel="icon" type="image/png" href="assets/favicon/favicon-16x16.png" sizes="16x16">
</head>

<body>
    <div id="app"></div>
<script type="text/javascript" src="main.44d1c937d2b2bb2c533b.js"></script></body>

</html>
/ # curl 10.100.0.50:2746/assets/styles/heebo.css
<!DOCTYPE html>
<html lang="en">

<head>
    <meta charset="UTF-8">
    <title>Argo</title>
    <base href="/infra/argo/">
    <link href="assets/styles/heebo.css" rel="stylesheet">
    <meta name="viewport" content="width=device-width, initial-scale=1">
    <meta name="robots" content="noindex">
    <link rel="icon" type="image/png" href="assets/favicon/favicon-32x32.png" sizes="32x32">
    <link rel="icon" type="image/png" href="assets/favicon/favicon-16x16.png" sizes="16x16">
</head>

<body>
    <div id="app"></div>
<script type="text/javascript" src="main.44d1c937d2b2bb2c533b.js"></script></body>

</html>

/ # curl 10.100.0.50:2746/infra/argo/assets/styles/heebo.css
<!DOCTYPE html>
<html lang="en">

<head>
    <meta charset="UTF-8">
    <title>Argo</title>
    <base href="/infra/argo/">
    <link href="assets/styles/heebo.css" rel="stylesheet">
    <meta name="viewport" content="width=device-width, initial-scale=1">
    <meta name="robots" content="noindex">
    <link rel="icon" type="image/png" href="assets/favicon/favicon-32x32.png" sizes="32x32">
    <link rel="icon" type="image/png" href="assets/favicon/favicon-16x16.png" sizes="16x16">
</head>

<body>
    <div id="app"></div>
<script type="text/javascript" src="main.44d1c937d2b2bb2c533b.js"></script></body>

</html>
/ # Session ended, resume using 'kubectl attach shell -c shell -i -t' command when the pod is running
pod "shell" deleted
hugh@dev:~$

Message from the maintainers:

Impacted by this bug? Give it a 👍. We prioritise the issues with the most 👍.
@alexec alexec self-assigned this Dec 14, 2020
alexec added a commit to alexec/argo-workflows that referenced this issue Dec 14, 2020
@alexec
fix(ui): Remove unused Heebo files. Fixes argoproj#4730
de9b54b 
Signed-off-by: Alex Collins <alex_collins@intuit.com>
@alexec alexec mentioned this issue Dec 14, 2020
Merged
1 task
alexec added a commit that referenced this issue Dec 15, 2020
@alexec
fix(ui): Remove unused Heebo files. Fixes #4730 (#4739)
625e3ce 
Signed-off-by: Alex Collins <alex_collins@intuit.com>
@hughobrien
Copy link
Author

thank you for the super-quick analysis/resolution!

@simster7 simster7 mentioned this issue Dec 17, 2020
Closed
9 tasks
@simster7 simster7 mentioned this issue Jan 4, 2021
Closed
21 tasks
@alexec alexec mentioned this issue Jan 18, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexec alexec

Labels
type/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(ui): Remove unused Heebo files. Fixes #4730 alexec/argo-workflows
2 participants
@alexec @hughobrien