Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry pick for v2.12.3 #4826

Closed
6 of 21 tasks
simster7 opened this issue Jan 4, 2021 · 2 comments
Closed
6 of 21 tasks

Cherry pick for v2.12.3 #4826

simster7 opened this issue Jan 4, 2021 · 2 comments

Comments

@simster7
Copy link
Member

simster7 commented Jan 4, 2021 •
edited by alexec

@alexec
Copy link
Contributor

alexec commented Jan 4, 2021

a0024d0 will produce conflicts:

  • For manifests/base/workflow-controller/workflow-controller-deployment.yaml, you want ports: and livenessProbe:. We do not want LEADER_ELECTION_IDENTITY.
  • For Procfile - we do not want LEADER_ELECTION_IDENTITY.
  • For the generated files, run make codegen to fix them.

@simster7
Copy link
Member Author

simster7 commented Jan 5, 2021

Release done

@simster7 simster7 closed this as completed Jan 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@simster7 @alexec