Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v2.12: EstimatorFactory can result in >1Gi memory usage #4801

Closed
alexec opened this issue Dec 24, 2020 · 1 comment · Fixed by #4808
Closed

v2.12: EstimatorFactory can result in >1Gi memory usage #4801

alexec opened this issue Dec 24, 2020 · 1 comment · Fixed by #4808
Assignees
@alexec
Labels
type/bug type/regression Regression from previous behavior (a specific type of bug)

Comments

@alexec
Copy link
Contributor

alexec commented Dec 24, 2020

Summary

util.FromUnstructured does a lot of memory allocations, especially in loops. If we have access to an unstructured.Unstructured and only need some of the information (any metadata, one or two fields) then we do not need to invoke it.

Over time this type will start doing very large allocs resulting in rampant memory usage.

Fix: https://github.com/argoproj/argo/pull/4795/files#diff-c5ce6b47371bfd1984ffff5b3c51c4a92ac0af836a74b079d25bb79774cdc84aR49
@alexec alexec added type/bug epic/scaling type/regression Regression from previous behavior (a specific type of bug) labels Dec 24, 2020
@alexec alexec self-assigned this Dec 24, 2020
alexec added a commit to alexec/argo-workflows that referenced this issue Dec 29, 2020
@alexec
fix(controller): Various v2.12 fixes. Fixes argoproj#4798, argoproj#4801
996afc8 
, argoproj#4806, argoproj#3551

Signed-off-by: Alex Collins <alex_collins@intuit.com>
@alexec alexec mentioned this issue Dec 29, 2020
Merged
1 task
@alexec alexec linked a pull request Dec 29, 2020 that will close this issue
fix(controller): Various v2.12 fixes. Fixes #4798, #4801, #4806 #4808
Merged
1 task
alexec added a commit that referenced this issue Jan 4, 2021
@alexec
fix(controller): Various v2.12 fixes. Fixes #4798, #4801, #4806 (#4808)
a0024d0 
Signed-off-by: Alex Collins <alex_collins@intuit.com>
@simster7 simster7 mentioned this issue Jan 4, 2021
Closed
21 tasks
simster7 pushed a commit that referenced this issue Jan 4, 2021
@alexec @simster7
fix(controller): Various v2.12 fixes. Fixes #4798, #4801, #4806 (#4808)
8177b53 
Signed-off-by: Alex Collins <alex_collins@intuit.com>
saranyaeu2987 pushed a commit to saranyaeu2987/argo-1 that referenced this issue Jan 5, 2021
@alexec @saranyaeu2987
fix(controller): Various v2.12 fixes. Fixes argoproj#4798, argoproj#4801
605cbde 
, argoproj#4806 (argoproj#4808)

Signed-off-by: Alex Collins <alex_collins@intuit.com>
Signed-off-by: saranyaeu2987 <saranyaeu2987@gmail.com>
@simster7
Copy link
Member

simster7 commented Jan 5, 2021

Fix for this is out on https://github.com/argoproj/argo/releases/tag/v2.12.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexec alexec

Labels
type/bug type/regression Regression from previous behavior (a specific type of bug)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(controller): Various v2.12 fixes. Fixes #4798, #4801, #4806 alexec/argo-workflows
2 participants
@simster7 @alexec