Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unknown time zone #5181

Closed
bryanisgreat opened this issue Feb 23, 2021 · 3 comments · Fixed by #5182
Closed

unknown time zone #5181

bryanisgreat opened this issue Feb 23, 2021 · 3 comments · Fixed by #5182
Assignees
@alexec
Labels
type/bug

Comments

@bryanisgreat
Copy link

Summary

v3.0.0-rc2 regresssion from this #5057 causing LoadLocation to not find timezone by name.

This issue is not present in v3.0.0-rc1

Diagnostics

EKS 1.17

v3.0.0-rc2

time="2021-02-23T18:17:17.550Z" level=error msg="could not run outstanding Workflow" cronWorkflow=prod/foobar error="invalid timezone 'America/Los_Angeles': unknown time zone America/Los_Angeles"

Message from the maintainers:

Impacted by this bug? Give it a 👍. We prioritise the issues with the most 👍.
@alexec alexec self-assigned this Feb 23, 2021
@alexec
Copy link
Contributor

alexec commented Feb 23, 2021

that's odd:

COPY --from=workflow-controller-build /usr/share/zoneinfo /usr/share/

I wonder what happenid.

@bryanisgreat
Copy link
Author

yeah, seems like that should work... It's possible that is not the cause, but it is quite suspect since it's behaving like the zoneinfo is missing.

@alexec
Copy link
Contributor

alexec commented Feb 23, 2021

https://stackoverflow.com/questions/59094236/error-unknown-time-zone-america-los-angeles-in-time-loadlocation

alexec added a commit to alexec/argo-workflows that referenced this issue Feb 23, 2021
@alexec
fix(controller): Fix timezone support. Fixes argoproj#5181
121cc06 
Signed-off-by: Alex Collins <alex_collins@intuit.com>
alexec added a commit to alexec/argo-workflows that referenced this issue Feb 23, 2021
@alexec
fix(controller): Fix timezone support. Fixes argoproj#5181
0f58002 
Signed-off-by: Alex Collins <alex_collins@intuit.com>
@alexec alexec mentioned this issue Feb 23, 2021
Merged
alexec added a commit that referenced this issue Feb 24, 2021
@alexec
fix(controller): Fix timezone support. Fixes #5181 (#5182)
e5a5f03 
Signed-off-by: Alex Collins <alex_collins@intuit.com>
@simster7 simster7 mentioned this issue Mar 1, 2021
Closed
32 tasks
simster7 pushed a commit that referenced this issue Mar 2, 2021
@alexec @simster7
fix(controller): Fix timezone support. Fixes #5181 (#5182)
db65775 
Signed-off-by: Alex Collins <alex_collins@intuit.com>
@simster7 simster7 mentioned this issue Mar 8, 2021
Closed
@alexec alexec mentioned this issue Apr 17, 2021
Closed
@simster7 simster7 mentioned this issue Apr 19, 2021
Closed
50 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexec alexec

Labels
type/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(controller): Fix timezone support. Fixes #5181 alexec/argo-workflows
2 participants
@alexec @bryanisgreat