Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timezone for CronWorkflow not working for all expected zones #5653

Closed
endzyme opened this issue Apr 12, 2021 · 8 comments · Fixed by #5712
Closed

Timezone for CronWorkflow not working for all expected zones #5653

endzyme opened this issue Apr 12, 2021 · 8 comments · Fixed by #5712
Assignees
Labels
Milestone

Comments

@endzyme
Copy link

endzyme commented Apr 12, 2021

Summary

Timezone settings for CronWorkflows don't appear to work for all expected timezones. I have set a timezone of Europe/Dublin and the controller does not actually start the job. There are some log messages that it is processing the job but nothing appears to start. When I changed to America/New_York or Europe/Paris it appears to work. I have also tested with Etc/GMT-1 and Europe/Amsterdam and same results, no worky.

Diagnostics

What version of Argo Workflows are you running?
v3.0.1

I will provide logs if needed.


Message from the maintainers:

Impacted by this bug? Give it a 👍. We prioritise the issues with the most 👍.

@alexec alexec added this to the v3.0 milestone Apr 12, 2021
@alexec alexec added the P3 label Apr 12, 2021
@alexec
Copy link
Contributor

alexec commented Apr 12, 2021

@simster7 ?

@simster7
Copy link
Member

Will take a look

@simster7 simster7 self-assigned this Apr 12, 2021
@alexec
Copy link
Contributor

alexec commented Apr 17, 2021

@endzyme can you please confirm if this worked in v2.12?

@alexec
Copy link
Contributor

alexec commented Apr 17, 2021

Related?

fix(controller): Fix timezone support. Fixes #5181 (#5182)

@endzyme
Copy link
Author

endzyme commented Apr 18, 2021

@endzyme can you please confirm if this worked in v2.12?

It did, but I'll try to spin something up this coming week to provide proof. I saw your note on the related Dockerfile change. It's likely related but I haven't fully dug into why some timezones would work and others would not.

@alexec
Copy link
Contributor

alexec commented Apr 19, 2021

time="2021-04-19T15:33:18.696Z" level=error msg="could not schedule CronWorkflow" cronWorkflow=argo/test-cron-wf-basic error="provided bad location Europe/Dublin: unknown time zone Europe/Dublin"

@alexec
Copy link
Contributor

alexec commented Apr 19, 2021

time="2021-04-19T15:34:45.881Z" level=error msg="could not schedule CronWorkflow" cronWorkflow=argo/test-cron-wf-basic error="provided bad location America/New_York: unknown time zone America/New_York"

alexec added a commit to alexec/argo-workflows that referenced this issue Apr 19, 2021
Signed-off-by: Alex Collins <alex_collins@intuit.com>
@alexec alexec linked a pull request Apr 19, 2021 that will close this issue
@simster7 simster7 mentioned this issue Apr 19, 2021
50 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants