fix: change pod OwnerReference to clean workflowtaskresults in large-scale scenarios #11048
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shuangkun
changed the title
maxsxu
reviewed
May 8, 2023
workflow/executor/taskresult.go
Outdated
| @@ -52,7 +52,7 @@ func (we *WorkflowExecutor) createTaskResult(ctx context.Context, result wfv1.No | |||
| []metav1.OwnerReference{ | |||
| { | |||
| APIVersion: "v1", | |||
| Kind: "pods", | |||
| Kind: "pod", | |||
There was a problem hiding this comment.
Suggested change
| Kind: "pod", | |
| Kind: "Pod", |
There was a problem hiding this comment.
Already edited. Thanks.
…cale scenarios Signed-off-by: shuangkun <tsk2013uestc@163.com>
shuangkun
changed the title
maxsxu
approved these changes
May 8, 2023
terrytangyuan
approved these changes
May 8, 2023
3 tasks
44 tasks
terrytangyuan
pushed a commit
that referenced
this pull request
May 25, 2023
…scale scenarios (#11048) Signed-off-by: shuangkun <tsk2013uestc@163.com>
JPZ13
pushed a commit
to pipekit/argo-workflows
that referenced
this pull request
Jul 4, 2023
…scale scenarios (argoproj#11048) Signed-off-by: shuangkun <tsk2013uestc@163.com>
5 tasks
6 tasks
dpadhiar
pushed a commit
to dpadhiar/argo-workflows
that referenced
this pull request
May 9, 2024
…scale scenarios (argoproj#11048) Signed-off-by: shuangkun <tsk2013uestc@163.com> Signed-off-by: Dillen Padhiar <dillen_padhiar@intuit.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In large-scale scenarios on cloud, we find the are so many workflowtaskresults left in the cluster (over a million), causing the cluster to fail to work. After investigation, we determined that there is something wrong with the pod owner reference.