REQUEST: Promotion to Reviewer for @shuangkun

[shuangkun]

GitHub Username

@shuangkun

Sub-project(s)

Promotion is requested for the following sub-project(s).

• Argo CD
• Argo Events
• Argo Rollouts
• Argo Workflows

Requirements

• Member for at least 3 months (as of the membership meeting date)
• Reviewer for or author of at least 5 substantial PRs to the codebase
  Authored：
  • < offload the envtemplate to support long arguments> feat: support long arguments argo-workflows#12325
  • < parallel resolve reference to speed up execution of large workflow > feat: speed up resolve reference argo-workflows#12328
  • < update command for cron/wft/cwft > feat: Add update command for cron,template,cluster-template. Fixes: #5464 #7344 argo-workflows#12803
  • < move delete logic from server to controller > refactor: change the logic of delete pod during retry. Fixes: #12538 argo-workflows#12734
  • < enable scheduling constraints in step/dag level > feat: support dag and steps level scheduling constraints. Fixes: #12568 argo-workflows#12700
  • < enable dynamic template reference naming > feat: support dynamic templateref naming. Fixes: #10542 argo-workflows#12842
  • < raise and resolve issues in large workflow >
    fix: ensure workflowtaskresults complete before mark workflow completed status. Fixes: #12615 argo-workflows#12574
    fix: make sure taskresult completed when mark node succeed when it has outputs argo-workflows#12537
    fix: change pod OwnerReference to clean workflowtaskresults in large-scale scenarios argo-workflows#11048
  • < locate the causes of some very important stuck issues about workflow/containerset/terminating >
    fix: delete pending pod when workflow terminated  argo-workflows#12196
    fix: workflow stuck in running state when using activeDeadlineSeconds on template level. Fixes: #12329 argo-workflows#12761
    fix(containerSet): mark container deleted when pod deleted. Fixes: #12210 argo-workflows#12756
  • < fixed some issues with core workflow logict about retryStrategy/memoize/hook/loop/dag/containerOn/artifacts/http/exector/data/resouce/server/controller>
    fix: cache configmap don't create with workflow has retrystrategy. Fixes: #12490 #10426 argo-workflows#12491
    fix: find correct retry node when using templateRef. Fixes: #12633 argo-workflows#12683
    fix: filter hook node to find the correct lastNode. Fixes: #12109 argo-workflows#12815
    fix: nodeAntiAffinity is not working as expected when boundaryID is empty. Fixes: #9193 argo-workflows#12701
    fix: DAG with continueOn in error after retry. Fixes: #11395 argo-workflows#12817
    fix: remove completed taskset status before update workflow. Fixes: #12832 argo-workflows#12835
    fix: make sure Finalizers has chance to be removed. Fixes: #12836 argo-workflows#12831
    fix: pass dnsconfig to agent pod. Fixes: #12824 argo-workflows#12825
    fix: return itself when getOutboundNodes from memoization Hit steps/DAG. Fixes: #7873 argo-workflows#12780
    fix(server): pass through burst and qps for auth.kubeclient argo-workflows#12575
    fix: Mark resource && data template report-outputs-completed true argo-workflows#12544
    feat: delete pods in parallel to speed up retryworkflow argo-workflows#12419
    fix: return failed instead of success when no container status argo-workflows#12197
    fix: oss list bucket return all records argo-workflows#12084

Totol Authored 52 / 44 Merged

Reviewed

Issues

Other Notes:

I am the fourth in the past 6months on the CNCF DevStats for Argo Workflows.

I have over three years of experience using and troubleshooting Argo Workflows issues on my team. My team also participated in the Argo workflow community contribution very early and member has participated in maintaining it before. Hoping to make more contributions in the future.

Lead Sponsor(s)

Promotion to Reviewer requires sponsorship from at least one sub-project Lead.

• @ terrytangyuan

Other Sponsors

• @ tczhao
• @ juliev0

[tczhao]

+1
sounds good to me
just keep in mind the responsibility as a reviewer
https://github.com/argoproj/argoproj/blob/main/community/membership.md#responsibilities-and-privileges-1

[terrytangyuan]

+1

[juliev0]

+1 no doubt - Shuangkun has tackled a significant number of high priority core bugs in the last few months at a serious velocity.

[sarabala1979]

+1.Thanks Shuangkun for your contribution

[agilgur5]

+1 Shuangkun has contributed quite a bit and is generally very responsive. He also tests well and has added many test cases (as well as fixed some flakes).