chore: mark more files as generated #11321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- several more files/folders that are generated (and _not_ `.gitignore`'d) - Java SDK docs are auto-generated, similar to Python - CRDs are auto-generated - quick start manifests are auto-generated from the other manifests - top-level JSONSchema and OpenAPI spec/Swagger are auto-generated from other files - did not include some auto-generated Go files as GitHub is already picking up those by default - i.e. `*.pb.go`, `*.pb.gw.go`, etc Signed-off-by: Anton Gilgur <agilgur5@gmail.com>
agilgur5
changed the title
terrytangyuan
approved these changes
Jul 9, 2023
|
The default diff in #11325 does look decently cleaner now! 🙂 Also this seems to be testable in-PR. Prior to rebasing with |
agilgur5
added
the
area/contributing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
There are several more files/folders that are generated (and not
.gitignore'd)c.f. GitHub Docs
Modifications
Java SDK docs are generated, similar to Python
CRDs are generated
quick start manifests are generated from the other manifests
top-level JSONSchema and OpenAPI spec/Swagger are generated from other files
did not include some auto-generated Go files as GitHub is already picking up those by default
*.pb.go,*.pb.gw.go, etcgo-to-protobufdetectionVerification
Notes for Reviewers
I do believe there are more generated files, but I wasn't as sure about those so did not include them. Can include them with confirmations. For instance,
pkg/client/, which I believe is generated heredocs/fields.mdanddocs/cli/argo.mdas those are user-facing docs, so potentially(??) good to code review and remind that some comments are user-facing etc. That's just my opinion so far though, could change / be changed