Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Snyk] Upgrade monaco-editor from 0.20.0 to 0.40.0 #11475

Closed

Conversation

sarabala1979
Copy link
Member

This PR was automatically created by Snyk using the credentials of a real user.


Snyk has created this PR to upgrade monaco-editor from 0.20.0 to 0.40.0.

ℹ️ Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project.


  • The recommended version is 493 versions ahead of your current version.
  • The recommended version was released 21 days ago, on 2023-07-07.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs.

For more information:

🧐 View latest project report

🛠 Adjust upgrade PR settings

🔕 Ignore this dependency or unsubscribe from future upgrade PRs

@agilgur5 agilgur5 added the type/dependencies PRs and issues specific to updating dependencies label Aug 15, 2023
@agilgur5
Copy link
Member

Taking a look as requested in the contributor meeting today.

The build error here is actually different than I expected, looks like it might just require the monaco-editor-webpack-plugin to also be upgraded.
Well and we'll have to see if that causes any knock-on effects or if other build errors will show up after that (e.g. I suspected that react-monaco-editor could be impacted, which could have some React 17 follow-ons)

@agilgur5 agilgur5 added the javascript Pull requests that update Javascript dependencies label Aug 16, 2023
@agilgur5
Copy link
Member

Was able to partially upgrade in #11593, but per the PR, there are some build system upgrades necessary to get all the way up to 0.40.0 (also 0.41.0 is latest now).

Upgraded to 0.30 for now, which did indeed require updating the Webpack plugin. See #11593 for more details

@agilgur5
Copy link
Member

@terrytangyuan I was going to leave this open until we got monaco-editor to 0.40.0+

@agilgur5 agilgur5 reopened this Aug 17, 2023
@agilgur5 agilgur5 self-assigned this Aug 17, 2023
@sarabala1979
Copy link
Member Author

@agilgur5 I will close it. Synk will open once it has a new version.

@terrytangyuan terrytangyuan deleted the snyk-upgrade-c1559f121ee16074b60753fd2f120ba1 branch August 28, 2023 20:03
@agilgur5
Copy link
Member

It will, but we're not even on 0.40.0 yet. This will also require manual intervention and testing either way as there are several related dependencies and configurations that often (but not always) require changing simultaneously.

@agilgur5
Copy link
Member

Snyk opened #11699, which indeed failed to build for reasons I mentioned above. See my comment #11699 (comment)

I have updated the monaco-editor deps simultaneously myself in #11710 and tested it to ensure it is working.

@agilgur5 agilgur5 added the solution/superseded This PR or issue has been superseded by another one (slightly different from a duplicate) label Feb 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
javascript Pull requests that update Javascript dependencies solution/superseded This PR or issue has been superseded by another one (slightly different from a duplicate) type/dependencies PRs and issues specific to updating dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants