Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update monaco-editor to latest 0.41.0 #11710

Merged
merged 1 commit into from
Aug 30, 2023

Conversation

agilgur5
Copy link
Member

Follow-up to #11593, which needed a Webpack upgrade (#11628) before it could be further upgraded.
Closes #11475
Closes #11699
See #11598 (comment) and later comments regarding react-monaco-editor

Motivation

Updated a fairly outdated dependency that Snyk was complaining about.
Same as #11593, was asked to look into Snyk's PRs.

Modifications

Verification

  • Install succeeds, build passes.
  • Seems to be working fine when running locally:
    Screenshot 2023-08-29 at 6 09 57 PM

- changelog analysis:
  - [0.31.0](https://github.com/microsoft/monaco-editor/blob/v0.41.0/CHANGELOG.md#0310-10122021) now builds since we are now on Webpack v5 (as of aac4f89)
  - 0.32.0 - [0.35.0](https://github.com/microsoft/monaco-editor/blob/v0.41.0/CHANGELOG.md#0350) breaking changes do not impact our usage
  - 0.36.0 - [0.41.0](https://github.com/microsoft/monaco-editor/blob/v0.41.0/CHANGELOG.md#0410) no breaking changes listed, all renames do not impact our usage

- also update `monaco-editor-webpack-plugin` to latest 7.1.0
  - per the [version matrix](https://github.com/microsoft/monaco-editor/tree/v0.41.0/webpack-plugin#version-matrix), 7.x.x is needed for `monaco-editor` >= 0.31.0

Signed-off-by: Anton Gilgur <agilgur5@gmail.com>
@agilgur5 agilgur5 added type/dependencies PRs and issues specific to updating dependencies area/ui javascript Pull requests that update Javascript dependencies labels Aug 29, 2023
@agilgur5
Copy link
Member Author

Seems like lint timed out again. Needs a retry 😕

I can bump that by a few minutes in a separate PR since this is now at least the second time that's happened

@terrytangyuan terrytangyuan enabled auto-merge (squash) August 30, 2023 00:40
@terrytangyuan terrytangyuan merged commit 7b72c0d into argoproj:master Aug 30, 2023
23 checks passed
@agilgur5 agilgur5 deleted the deps-monaco-update-part2 branch August 30, 2023 01:47
@agilgur5
Copy link
Member Author

agilgur5 commented Sep 4, 2023

I can bump that by a few minutes in a separate PR since this is now at least the second time that's happened

Bumped in #11745

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ui javascript Pull requests that update Javascript dependencies type/dependencies PRs and issues specific to updating dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants