fix: Revert #11761 to avoid argo-server performance issue #12068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 23, 2023
Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
|
Just want to make sure - can you confirm that there are no changes that were made after this change that were dependent on it? |
terrytangyuan
force-pushed
the
revert-pagination-fix
branch
from
8285e83
to
5709bf0
Compare
Yes that is the last change to https://github.com/argoproj/argo-workflows/blob/master/server/workflow/workflow_server.go |
juliev0
approved these changes
Oct 23, 2023
terrytangyuan
added a commit
that referenced
this pull request
Nov 3, 2023
Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
3 tasks
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts #11761. See #12025 for context.