feat: speed up resolve reference #12328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shuangkun
force-pushed
the
feature/SpeepUpResolveReference
branch
from
a82c424
to
3265886
Compare
5 tasks
shuangkun
force-pushed
the
feature/SpeepUpResolveReference
branch
3 times, most recently
from
3c9921c
to
8498c0b
Compare
shuangkun
force-pushed
the
feature/SpeepUpResolveReference
branch
from
8498c0b
to
2893ce1
Compare
agilgur5
added
area/controller
juliev0
reviewed
Jan 13, 2024
shuangkun
force-pushed
the
feature/SpeepUpResolveReference
branch
2 times, most recently
from
6e16be0
to
e0b847c
Compare
juliev0
reviewed
Jan 14, 2024
workflow/controller/steps.go
Outdated
| go func(i int, step wfv1.WorkflowStep) { | ||
| defer wg.Done() | ||
| if err := resolveStepReferences(i, step, newStepGroup); err != nil { | ||
| woc.log.WithFields(log.Fields{"stepName": step.Name}).WithError(err).Error(err.Error()) |
There was a problem hiding this comment.
Just want to make sure - would we possibly print the error twice? I'm looking at WithError(err).Error(err.Error())
Signed-off-by: shuangkun <tsk2013uestc@163.com>
shuangkun
force-pushed
the
feature/SpeepUpResolveReference
branch
from
e0b847c
to
fe2b1aa
Compare
juliev0
approved these changes
Jan 15, 2024
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have a big and flat workflow( 2000+ ) pod, which have artifacts reference each step. I find it won’t continue running down when it run to around step 100～200.
After investigation， I find the function "resolveReferences" is too slow. One Step Group node has 1000 step need 300s to resolveReferences and then update the Step Group succeed. After that, then the workflow can run down. But the default time for woc.operator is 30s. I have set MAX_OPERATION_TIME to 20 min to succeed the workflow. But I think there is a better solution.
So I want to speed up resolve reference.
I print the step time when it change to newStepStr use "template.Replace". Maybe I will speed up the "template.Replace" function future.
Fixes #TODO
Motivation
Modifications
Verification
Beyond this PR