fix: custom columns not supporting annotations #12421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- [x] search annotations for matching key from user's custom column type - docs state we can use labels and annotations [here](https://github.com/argoproj/argo-workflows/blob/954884d64c7b2d24a2e5fa0641a66692d182fefd/pkg/apis/workflow/v1alpha1/info.go#L21) and [here](https://github.com/argoproj/argo-workflows/blob/954884d64c7b2d24a2e5fa0641a66692d182fefd/docs/workflow-controller-configmap.yaml#L90) Signed-off-by: jmeridth <jmeridth@gmail.com> Co-authored-by: Steven Johnson <52087249+stevenbjohnson@users.noreply.github.com>
jmeridth
force-pushed
the
jm-custom-columns-fixes
branch
from
a453da2
to
b46c480
Compare
agilgur5
reviewed
Dec 29, 2023
ui/src/app/workflows/components/workflows-row/workflows-row.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Anton Gilgur <4970083+agilgur5@users.noreply.github.com> Signed-off-by: Jason Meridth <jmeridth@gmail.com>
Signed-off-by: jmeridth <jmeridth@gmail.com>
agilgur5
approved these changes
Dec 29, 2023
hittingray
pushed a commit
to atlassian-forks/argo-workflows
that referenced
this pull request
Jan 3, 2024
Signed-off-by: jmeridth <jmeridth@gmail.com> Signed-off-by: Jason Meridth <jmeridth@gmail.com> Co-authored-by: Steven Johnson <52087249+stevenbjohnson@users.noreply.github.com> Co-authored-by: Anton Gilgur <4970083+agilgur5@users.noreply.github.com>
sarabala1979
pushed a commit
that referenced
this pull request
Jan 9, 2024
Signed-off-by: jmeridth <jmeridth@gmail.com> Signed-off-by: Jason Meridth <jmeridth@gmail.com> Co-authored-by: Steven Johnson <52087249+stevenbjohnson@users.noreply.github.com> Co-authored-by: Anton Gilgur <4970083+agilgur5@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12422
Motivation
We'd like to add a PR column that lists the user's PR URL and using annotations since labels have character limits and don't support special characters.
Builds off #10808
Modifications
Verification
I changed this file's columns section from:
to
and added the follow to a workflow's annotations:
Reference screenshot above for result