Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Expose customized UI links and columns #10808

Merged
merged 3 commits into from
Apr 6, 2023

Conversation

rbreeze
Copy link
Member

@rbreeze rbreeze commented Apr 3, 2023

Fixes #10447

The following in workflow-controller-configmap.yaml:

data: 
  links:
    - name: Completed Workflows
      scope: workflow-list
      url: http://workflows?label=workflows.argoproj.io/completed=true
  columns: |
    - name: Workflow Completed
      type: label
      key: workflows.argoproj.io/completed

yields:

Screenshot 2023-04-03 at 10 08 20

Signed-off-by: Remington Breeze <remington@breeze.software>
Signed-off-by: Remington Breeze <remington@breeze.software>
@rbreeze rbreeze requested review from alexec and alexmt April 3, 2023 22:21
Copy link
Member

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The changes are pretty straightforward. Would you like to add some documentation around it? For example, how to enable this in configmap.

@terrytangyuan terrytangyuan changed the title feat: expose customized UI links and columns feat: Expose customized UI links and columns Apr 6, 2023
@rbreeze
Copy link
Member Author

rbreeze commented Apr 6, 2023

Sure thing! Will add docs in a separate PR

@rbreeze rbreeze merged commit 49890ec into argoproj:master Apr 6, 2023
@rbreeze rbreeze deleted the custom-ui branch April 6, 2023 21:47
JPZ13 pushed a commit to pipekit/argo-workflows that referenced this pull request Jul 4, 2023
Signed-off-by: Remington Breeze <remington@breeze.software>
@tooptoop4
Copy link
Contributor

this looks great, when will it be released?

@terrytangyuan
Copy link
Member

It will be part of v3.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Customizable Argo UI (navigation links, custom columns)
3 participants