-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(server): pass through burst and qps for auth.kubeclient #12575
Conversation
Signed-off-by: shuangkun <tsk2013uestc@163.com>
Signed-off-by: shuangkun <tsk2013uestc@163.com>
For reference for other readers, this PR takes the burst and QPS from the Server's configuration in the CLI and passes it through to the auth I think that makes sense to do, but it wasn't clear from the PR where the |
If this is just pass through, this might make sense as a |
https://github.com/argoproj/argo-workflows/blob/main/cmd/argo/commands/server.go config.Burst = kubeAPIBurst
config.QPS = kubeAPIQPS |
OK i will change it |
a8c9b90
to
f8dee84
Compare
f8dee84
to
92c0a25
Compare
Signed-off-by: shuangkun <tsk2013uestc@163.com>
Signed-off-by: shuangkun <tsk2013uestc@163.com>
a2810b7
to
1889c56
Compare
1889c56
to
745b0c8
Compare
Signed-off-by: shuangkun <tsk2013uestc@163.com>
121eabc
to
71a6d82
Compare
Thanks! |
Signed-off-by: shuangkun <tsk2013uestc@163.com>
Signed-off-by: shuangkun <tsk2013uestc@163.com>
Signed-off-by: shuangkun <tsk2013uestc@163.com> Signed-off-by: Isitha Subasinghe <isubasinghe@student.unimelb.edu.au>
Signed-off-by: shuangkun <tsk2013uestc@163.com>
Signed-off-by: shuangkun <tsk2013uestc@163.com>
Signed-off-by: shuangkun <tsk2013uestc@163.com>
When I submit or access a large number of workflows at the same time in argo-server URL,I encountered many client-side throttling which let my request slow, I find the root cause is the client in workflow_server.go 's burst and qps is 0. So I want to increase it. After I added it, it was fine. There is no throttling.
some log in argo server