feat: support dag and steps level scheduling constraints. Fixes: #12568 #12700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shuangkun
added
area/controller
Joibel
requested changes
Mar 6, 2024
| @@ -815,6 +826,28 @@ func addSchedulingConstraints(pod *apiv1.Pod, wfSpec *wfv1.WorkflowSpec, tmpl *w | |||
| } | |||
| } | |||
|
|
|||
| // GetBoundaryTemplate get a template through the node's BoundaryID. | |||
| func (woc *wfOperationCtx) GetBoundaryTemplate(nodeName string) (*wfv1.Template, error) { | |||
There was a problem hiding this comment.
Can something like this function also be used from
argo-workflows/workflow/controller/operator.go
Line 2740 in e00abd1
The two bits of code are very similar to each other, and it's good to extract common functionality whilst we're doing this kind of work.
This function could take a *NodeStatus instead
There was a problem hiding this comment.
I have made some reuses, please take a look，Thanks.
Signed-off-by: shuangkun <tsk2013uestc@163.com>
juliev0
approved these changes
Mar 15, 2024
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12568
Motivation
I want to Take effect dag and steps level scheduling constraints. Not just workflow level and template level.
Modifications
Find the pod's bounaryID's Template and add the scheduling constraints to pod if exists.
Verification
ut and e2e test