-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: filter hook node to find the correct lastNode. Fixes: #12109 #12815
Conversation
…2109 Signed-off-by: shuangkun <tsk2013uestc@163.com>
5262d9c
to
f8a264e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the operator changes look good but there are issues with the added test.
f8a264e
to
3a0dbba
Compare
Signed-off-by: shuangkun <tsk2013uestc@163.com>
c788103
to
5166a50
Compare
5166a50
to
823dec1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I see |
Signed-off-by: shuangkun <tsk2013uestc@163.com>
Yes, all places need to find correct last child node. |
Backported cleanly to |
Let retryStrategy AND hooks on a step works well.
Fixes #12109
Motivation
Modifications
Filter hook node to find the correct lastNode when buildLocalScope.
So the error
won't occur.
Verification
local test and e2e.