Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): bump undici from 5.28.3 to 5.28.4 in /ui #12891

Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Apr 4, 2024

Bumps the npm_and_yarn group in /ui with 1 update: undici.

Updates undici from 5.28.3 to 5.28.4

Release notes

Sourced from undici's releases.

v5.28.4

⚠️ Security Release ⚠️

Full Changelog: nodejs/undici@v5.28.3...v5.28.4

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore <dependency name> major version will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)
  • @dependabot ignore <dependency name> minor version will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)
  • @dependabot ignore <dependency name> will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)
  • @dependabot unignore <dependency name> will remove all of the ignore conditions of the specified dependency
  • @dependabot unignore <dependency name> <ignore condition> will remove the ignore condition of the specified dependency and ignore conditions
    You can disable automated security fix PRs for this repo from the Security Alerts page.

Bumps the npm_and_yarn group in /ui with 1 update: [undici](https://github.com/nodejs/undici).


Updates `undici` from 5.28.3 to 5.28.4
- [Release notes](https://github.com/nodejs/undici/releases)
- [Commits](nodejs/undici@v5.28.3...v5.28.4)

---
updated-dependencies:
- dependency-name: undici
  dependency-type: indirect
  dependency-group: npm_and_yarn
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added javascript Pull requests that update Javascript dependencies type/dependencies PRs and issues specific to updating dependencies labels Apr 4, 2024
@agilgur5 agilgur5 added the type/security Security related label Apr 4, 2024
@github-actions github-actions bot enabled auto-merge (squash) April 4, 2024 22:42
@agilgur5 agilgur5 changed the title chore(deps): bump undici from 5.28.3 to 5.28.4 in /ui in the npm_and_yarn group chore(deps): bump undici from 5.28.3 to 5.28.4 in /ui Apr 4, 2024
@agilgur5
Copy link
Member

agilgur5 commented Apr 4, 2024

Oh boy, now the git push line of the deduplicate step is failing CI due to #12234 (comment)

Run git config --global user.name 'github-actions[bot]'
  git config --global user.name 'github-actions[bot]'
  git config --global user.email 'github-actions[bot]@users.noreply.github.com'
  git add ui/yarn.lock
  git commit -s --allow-empty -m 'chore: deduplicate yarn.lock'
  git push
  shell: /usr/bin/bash -e {0}
  env:
    NODE_OPTIONS: --max-old-space-size=4096
[detached HEAD 4ab78f5] chore: deduplicate yarn.lock
fatal: You are not currently on a branch.
To push the history leading to the current (detached HEAD)
state now, use

    git push origin HEAD:<name-of-remote-branch>

Error: Process completed with exit code 1[2](https://github.com/argoproj/argo-workflows/actions/runs/8561962725/job/23464600770?pr=12880#step:9:2)8.

@agilgur5
Copy link
Member

agilgur5 commented Apr 5, 2024

Oh boy, now the git push line of the deduplicate step is failing CI due to #12234 (comment)

I fixed all the git push issues, but per #12234 (comment), the entire approach ended up being fundamentally unworkable and not properly tested, so I created a PR to revert it in #12892

@agilgur5 agilgur5 added this to the v3.5.x patches milestone Apr 5, 2024
@agilgur5
Copy link
Member

agilgur5 commented Apr 6, 2024

@dependabot rebase

@github-actions github-actions bot merged commit 026848c into main Apr 6, 2024
15 checks passed
@github-actions github-actions bot deleted the dependabot/npm_and_yarn/ui/npm_and_yarn-f588956305 branch April 6, 2024 02:36
agilgur5 added a commit that referenced this pull request Apr 9, 2024
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Anton Gilgur <4970083+agilgur5@users.noreply.github.com>
@agilgur5
Copy link
Member

agilgur5 commented Apr 9, 2024

Backported cleanly into release-3.5 as 4fb03ee

@agilgur5 agilgur5 changed the title chore(deps): bump undici from 5.28.3 to 5.28.4 in /ui fix(deps): bump undici from 5.28.3 to 5.28.4 in /ui Apr 10, 2024
isubasinghe pushed a commit to isubasinghe/argo-workflows that referenced this pull request May 7, 2024
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Anton Gilgur <4970083+agilgur5@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
javascript Pull requests that update Javascript dependencies type/dependencies PRs and issues specific to updating dependencies type/security Security related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant