Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(controller): set pod name version annotation when no lock #12965

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(controller): set pod name version annotation when no lock #12965

wants to merge 1 commit into from

Commits on Apr 22, 2024

  1. fix(controller): set pod name version annotation when no lock 

    - `setWfPodNamesAnnotation` was added to the `Unknown` phase check a few lines below this, but not to this line
  - these are the two places where `Unknown` is handled
  - without this, the annotation wouldn't be set if the workflow couldn't grab a lock, creating a mismatch when using synchronization

- also simplify the conditional into one with an `&&` rather than nesting
  - reducing nesting reduces code complexity

- slightly simplify `setWfPodNamesAnnotation` as well

Signed-off-by: Anton Gilgur <agilgur5@gmail.com>
    @agilgur5
    agilgur5 committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    8cad9bb View commit details
    Browse the repository at this point in the history