-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(deps): upgrade swagger-ui-react v5.17.3, react-dom v18.3.1, and react v18.3.1. Fixes CVEs #13069
fix(deps): upgrade swagger-ui-react v5.17.3, react-dom v18.3.1, and react v18.3.1. Fixes CVEs #13069
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
@@ -1,5 +1,7 @@ | ||||||||||||||
import * as React from 'react'; | ||||||||||||||
import * as ReactDOM from 'react-dom'; | ||||||||||||||
import {App} from './app'; | ||||||||||||||
import {createRoot} from 'react-dom/client'; | ||||||||||||||
Comment on lines
-2
to
+3
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. we should leave the import in the same place; the
Suggested change
I've been meaning to add an ESLint or Prettier plugin to auto sort imports for a bit now |
||||||||||||||
|
||||||||||||||
ReactDOM.render(<App />, document.getElementById('app')); | ||||||||||||||
const container = document.getElementById('app'); | ||||||||||||||
const root = createRoot(container!); | ||||||||||||||
Comment on lines
+5
to
+6
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
we can probably simplify this, the |
||||||||||||||
root.render(<App />); | ||||||||||||||
Comment on lines
+3
to
+7
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Followed https://react.dev/blog/2022/03/08/react-18-upgrade-guide