New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ui): Use LogsViewer for container logs #2825
fix(ui): Use LogsViewer for container logs #2825
Conversation
|
||
import {LogsViewer} from 'argo-ui'; | ||
import {LogsViewerProps} from 'argo-ui/src/components/logs-viewer/logs-viewer'; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I’d just in-line this file m
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I approve. I mentioned to @alexmt that we should provide filters on logs, eg just show errors. Maybe tomorrow.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the green on black is hard to read, but I realize this is the domain of LogsViewer
. Could you please include the workflow you used to reproduce this in the GitHub PR? No need to include it in the actual repository.
Run |
Will it be possible to configure "themes"? Different configurations for different users? |
Can you please sync with master and then run run |
Kudos, SonarCloud Quality Gate passed! 0 Bugs |
🚀 thank you! |
Checklist:
Fixes #2569
"fix(controller): Updates such and such. Fixes #1234"
.