Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): Use LogsViewer for container logs #2825

Merged
merged 8 commits into from May 1, 2020
Merged

fix(ui): Use LogsViewer for container logs #2825

merged 8 commits into from May 1, 2020

Conversation

dtaniwaki
Copy link
Member

@dtaniwaki dtaniwaki commented Apr 24, 2020

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.

Fixes #2569

  • The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed the CLA.
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

Screen Shot 2020-04-24 at 5 19 47 PM

@dtaniwaki dtaniwaki requested review from alexec and simster7 and removed request for alexec April 24, 2020 10:07

import {LogsViewer} from 'argo-ui';
import {LogsViewerProps} from 'argo-ui/src/components/logs-viewer/logs-viewer';

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’d just in-line this file m

Copy link
Contributor

@alexec alexec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve. I mentioned to @alexmt that we should provide filters on logs, eg just show errors. Maybe tomorrow.

Copy link
Member

@simster7 simster7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the green on black is hard to read, but I realize this is the domain of LogsViewer. Could you please include the workflow you used to reproduce this in the GitHub PR? No need to include it in the actual repository.

@dtaniwaki
Copy link
Member Author

Screen Shot 2020-04-25 at 2 11 47 PM

I added an example file which emits colored logs in the examples directory.

@alexec
Copy link
Contributor

alexec commented Apr 25, 2020

Run make docs to fix codegen job.

@tsadoklf
Copy link

Will it be possible to configure "themes"? Different configurations for different users?

@alexec alexec self-assigned this Apr 28, 2020
@alexec
Copy link
Contributor

alexec commented Apr 30, 2020

Can you please sync with master and then run run make docs to fix CI?

@sonarcloud
Copy link

sonarcloud bot commented May 1, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@alexec alexec merged commit 3afa7b2 into argoproj:master May 1, 2020
@alexec
Copy link
Contributor

alexec commented May 1, 2020

🚀 thank you!

@dtaniwaki dtaniwaki deleted the display-pod-logs-as-terminal-logs branch May 5, 2020 04:55
@dtaniwaki dtaniwaki mentioned this pull request May 5, 2020
4 tasks
@alexec alexec linked an issue May 5, 2020 that may be closed by this pull request
4 tasks
@alexec alexec added this to the v2.8 milestone May 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Logs UI is very CPU heavy Make log viewer compatible with output in color
4 participants