New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ui): Use LogsViewer for container logs #2825
Merged
alexec
merged 8 commits into
argoproj:master
from
dtaniwaki:display-pod-logs-as-terminal-logs
May 1, 2020
Merged
Changes from 2 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
a42265f
Use LogsViewer for container logs
dtaniwaki 6203ea9
Remove unnecessary variable
dtaniwaki 11fa0bf
Add colored logs example
dtaniwaki c3e3c52
Update docs
dtaniwaki ee7baaa
Add a comment in the example manifest
dtaniwaki 5276f8d
Merge remote-tracking branch 'upstream/master' into display-pod-logs-…
dtaniwaki ed2d8cd
Remove unnecessary example
dtaniwaki 34eb5c0
Merge remote-tracking branch 'upstream/master' into display-pod-logs-…
dtaniwaki File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
21 changes: 21 additions & 0 deletions
21
ui/src/app/workflows/components/workflow-logs-viewer/full-height-logs-viewer.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
import * as React from 'react'; | ||
|
||
import {LogsViewer} from 'argo-ui'; | ||
import {LogsViewerProps} from 'argo-ui/src/components/logs-viewer/logs-viewer'; | ||
|
||
export const FullHeightLogsViewer = (props: LogsViewerProps) => { | ||
const ref = React.useRef(null); | ||
const [height, setHeight] = React.useState<number>(null); | ||
const {source} = props; | ||
|
||
React.useEffect(() => { | ||
const parentElement = ref.current!.parentElement; | ||
setHeight(parentElement.getBoundingClientRect().height); | ||
}, [ref]); | ||
|
||
return ( | ||
<div ref={ref} style={{height}}> | ||
{height && <LogsViewer source={source} />} | ||
</div> | ||
); | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I’d just in-line this file m