fix: Cannot create WorkflowTemplate with un-supplied inputs #2869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simster7
reviewed
Apr 28, 2020
| @@ -172,7 +175,13 @@ func ValidateWorkflow(wftmplGetter templateresolution.WorkflowTemplateNamespaced | |||
| } | |||
|
|
|||
| if !opts.IgnoreEntrypoint { | |||
| _, err = ctx.validateTemplateHolder(&wfv1.WorkflowStep{Template: wf.Spec.Entrypoint}, tmplCtx, &wf.Spec.Arguments, map[string]interface{}{}) | |||
| var args wfv1.ArgumentsProvider | |||
| args = &wf.Spec.Arguments | |||
There was a problem hiding this comment.
Why not
Suggested change
| args = &wf.Spec.Arguments | |
| args := &wf.Spec.Arguments |
Instead of var args wfv1.ArgumentsProvider?
There was a problem hiding this comment.
FakeArgument is a separate struct. ArgumentsProvider is a common interface that used to pass either wfv1. Argument or FakeArgument.
|
Kudos, SonarCloud Quality Gate passed!
|
alexec
approved these changes
Apr 28, 2020
simster7
approved these changes
Apr 28, 2020
|
@sarabala1979 I think this bug fix need back-porting to v2.8? |
|
yes we need to do it |
sarabala1979
added a commit
that referenced
this pull request
May 27, 2020
|
The combination of this issue and the fact that 2.7.x doesn't support "{{workflow.status}}" for onExit templates of workflow-templates means we're waiting anxiously for this fix to go in. Is there an ETA on 2.8.1? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
"fix(controller): Updates such and such. Fixes #1234". Cannot create WorkflowTemplate with unsupplied inputs #2857