Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Cannot create WorkflowTemplate with un-supplied inputs #2869
fix: Cannot create WorkflowTemplate with un-supplied inputs #2869
Changes from 66 commits
64f6403
4a67b77
b318144
ccc86c7
4702130
3a11f82
44d8b51
07a41f9
3ac482d
0934b2a
5b4c201
0875e7b
9da394b
dff0204
3e2d0cd
1873bc1
b45c85d
b3fe528
ae62719
a49bebe
68097c1
48ece72
d151e8f
c4ebd48
b6653f6
d7b1503
d1e72e8
caf42aa
f2e2f43
a71f32d
46a86a1
0ba75d7
cd24fff
76c6b98
4aadd7a
484ff30
b123157
8c62154
1777b3f
655013f
e02a98c
f5e3c8f
da26c49
bfd8602
3046680
48d3a4b
b9f9d1d
f3098d3
a7c82b7
38bc2ee
b9dcbf0
fde23eb
45d0236
a0d6683
a63ec69
0145e5d
28ddbdf
2f6c39d
8d36b37
961adab
d738553
4acd70e
54fce61
766677f
d195796
53f7309
a8a5d13
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not
Instead of
var args wfv1.ArgumentsProvider
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FakeArgument is a separate struct.
ArgumentsProvider
is a common interface that used to pass either wfv1. Argument or FakeArgument.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, of course!