Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(artifacts): Revert allow tar check to be ignored. Reverts #3024 #3047

Merged
merged 1 commit into from May 15, 2020
Merged

fix(artifacts): Revert allow tar check to be ignored. Reverts #3024 #3047

merged 1 commit into from May 15, 2020

Conversation

alexec
Copy link
Contributor

@alexec alexec commented May 15, 2020 •
edited

This reverts commit a1ac8bc.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed the CLA.
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

See #3043

@alexec alexec changed the title Revert "fix(artifacts): Allow tar check to be ignored. Fixes #2140 (#… Revert "fix(artifacts): Allow tar check to be ignored. Reverts #3024 May 15, 2020
@alexec alexec requested a review from sarabala1979 May 15, 2020 15:54
@alexec alexec changed the title Revert "fix(artifacts): Allow tar check to be ignored. Reverts #3024 fix(artifacts): Revert allow tar check to be ignored. Reverts #3024 May 15, 2020
@alexec alexec marked this pull request as ready for review May 15, 2020 16:49
@alexec alexec merged commit ada2209 into argoproj:master May 15, 2020
@alexec alexec deleted the revert-3024 branch May 15, 2020 16:49
alexec added a commit to alexec/argo-workflows that referenced this pull request May 18, 2020
@alexec
Revert "Revert "fix(artifacts): Allow tar check to be ignored. Fixes a…
1e6bf22 
…rgoproj#2140 (argoproj#3024)" (argoproj#3047)"

This reverts commit ada2209.
@alexec alexec mentioned this pull request May 18, 2020
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simster7 simster7 simster7 approved these changes

@sarabala1979 sarabala1979 sarabala1979 approved these changes

Assignees
No one assigned
Labels
type/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@alexec @simster7 @sarabala1979