Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(artifacts): Explicit archive strategy. Fixes #2140 #3052

Merged
merged 4 commits into from May 19, 2020

Conversation

alexec
Copy link
Contributor

@alexec alexec commented May 18, 2020

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed the CLA.
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

Fixes #2140
See #3024, #3047

@sonarcloud
Copy link

sonarcloud bot commented May 18, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

47.8% 47.8% Coverage
0.0% 0.0% Duplication

@alexec alexec marked this pull request as ready for review May 18, 2020 19:36
@alexec alexec changed the title fix(artifacts): Allow tar check to be ignored. Fixes #2140 fix(artifacts): Prefer explicit archive strategy. Fixes #2140 May 18, 2020
@alexec alexec requested a review from sarabala1979 May 18, 2020 19:37
@alexec alexec changed the title fix(artifacts): Prefer explicit archive strategy. Fixes #2140 fix(artifacts): Explicit archive strategy. Fixes #2140 May 19, 2020
@alexec alexec merged commit 51dd05b into argoproj:master May 19, 2020
@alexec alexec deleted the feat-tar-none branch May 19, 2020 16:01
@agilgur5 agilgur5 added the area/artifacts S3/GCP/OSS/Git/HDFS etc label Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/artifacts S3/GCP/OSS/Git/HDFS etc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Concaternated 20GB GZIP Input Archives Cause Stalling
3 participants