feat: Add a minimal prometheus server manifest #4687
Conversation
Would be happy to. Today at standup? |
|
Stand-up demo - yes please. What would be neat? |
Will have this ready by standup time |
Signed-off-by: Simon Behar <simbeh7@gmail.com>
Makefile
Outdated
| ifeq ($(PROFILE),prometheus) | ||
| kubectl -n $(KUBE_NAMESPACE) scale deploy/prometheus --replicas 1 | ||
| endif | ||
| kubectl -n $(KUBE_NAMESPACE) wait --for=condition=Ready pod --all -l app --timeout 1m || true |
There was a problem hiding this comment.
In my experience kubectl wait hangs/gets stuck even after all pods are ready (which happens after around 30 seconds). Confirmed this by running the same command in another terminal window while it is stuck, and in that case the command completes successfully.
We still want to have a wait before we do port-forwarding, but we don't want this flakey command to kill start up, so I lowered the timeout and added || true to ensure this flakey command doesn't stop the build. If the pods actually aren't ready, the next command will fail anyway (which in my experience does not happen).
There was a problem hiding this comment.
I've noted this is flakey too. Could we make the wait specific? E.g.
kubectl -n $(KUBE_NAMESPACE) wait --for=condition=Ready pod -l app=prometheus
There was a problem hiding this comment.
might need a short sleep before hand
| @@ -3,12 +3,14 @@ kind: Kustomization | |||
|
|
|||
| resources: | |||
| - ../../../../manifests/quick-start/mysql | |||
| - ../../../../manifests/quick-start/base/prometheus | |||
There was a problem hiding this comment.
I don't think this will work, because RUN!=kubernetes typically , I think you only need to add to PROFILE=prometheus
|
@alexec Ready again |
Signed-off-by: Simon Behar simbeh7@gmail.com
Checklist: