fix(executor): Do not delete local artifacts after upload. Fixes #4676 #4697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…proj#4676 Signed-off-by: Alex Collins <alex_collins@intuit.com>
|
Left in draft pending testing by @antoniomo . |
|
LGTM, thank you! Test results on the issue, here: #4676 (comment) |
Signed-off-by: Alex Collins <alex_collins@intuit.com>
jessesuen
approved these changes
Dec 23, 2020
There was a problem hiding this comment.
I'm assuming REMOVE_LOCAL_ART_PATH is just an anti-feature gate, and is our escape hatch in case we break something unexpected with the change.
If so, I would just add a TODO comment saying this environment variable is temporary knob to disable the fix for #4676 (comment) and should be removed eventually
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Alex Collins alex_collins@intuit.com
Checklist: