Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(controller): Enhanced pod clean-up scalability #4728

Merged
merged 14 commits into from Dec 16, 2020
Merged

refactor(controller): Enhanced pod clean-up scalability #4728

merged 14 commits into from Dec 16, 2020

Conversation

alexec
Copy link
Contributor

@alexec alexec commented Dec 12, 2020 •
edited

Signed-off-by: Alex Collins alex_collins@intuit.com

Checklist:

@alexec
refactor(controller): Queue workqueue for pod GC
07d4f9c 
Signed-off-by: Alex Collins <alex_collins@intuit.com>
@alexec
gc-queue: M cmd/workflow-controller/main.go
04ae048 
Signed-off-by: Alex Collins <alex_collins@intuit.com>
@alexec
gc-queue: M workflow/ttlcontroller/ttlcontroller.go
a0d706a 
Signed-off-by: Alex Collins <alex_collins@intuit.com>
@alexec
gc-queue: M pkg/apis/workflow/v1alpha1/workflow_types.go
2268f39 
Signed-off-by: Alex Collins <alex_collins@intuit.com>
@alexec
Merge branch 'master' into gc-queue
600fbec 
Signed-off-by: Alex Collins <alex_collins@intuit.com>
@alexec alexec changed the title refactor(controller): Use workqueue for pod GC refactor(controller): Enhanced pod clean-up Dec 14, 2020
@alexec
gc-queue: M cmd/workflow-controller/main.go
f452bed 
Signed-off-by: Alex Collins <alex_collins@intuit.com>
@alexec
gc-queue: M cmd/workflow-controller/main.go
f7ec447 
Signed-off-by: Alex Collins <alex_collins@intuit.com>
@alexec
gc-queue: M pkg/apis/workflow/v1alpha1/workflow_types.go
9f82d4a 
Signed-off-by: Alex Collins <alex_collins@intuit.com>
@alexec alexec changed the title refactor(controller): Enhanced pod clean-up refactor(controller): Enhanced pod clean-up scalability Dec 14, 2020
@alexec
gc-queue: M test/e2e/functional_test.go
710055d 
Signed-off-by: Alex Collins <alex_collins@intuit.com>
@alexec
gc-queue: M test/e2e/functional_test.go
b76ebf8 
Signed-off-by: Alex Collins <alex_collins@intuit.com>
@alexec alexec marked this pull request as ready for review December 15, 2020 01:25
@sarabala1979 sarabala1979 self-assigned this Dec 15, 2020
@alexec
Merge branch 'master' into gc-queue
aaf7a43 
Signed-off-by: Alex Collins <alex_collins@intuit.com>
@alexec
gc-queue: M pkg/apis/workflow/v1alpha1/workflow_types.go
edcc720 
Signed-off-by: Alex Collins <alex_collins@intuit.com>
@alexec
Merge branch 'master' into gc-queue
b49413c 
Signed-off-by: Alex Collins <alex_collins@intuit.com>
@alexec
Merge branch 'master' into gc-queue
90cd55c 
Signed-off-by: Alex Collins <alex_collins@intuit.com>
sarabala1979
sarabala1979 approved these changes Dec 16, 2020
View reviewed changes
Copy link
Member

@sarabala1979 sarabala1979 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexec alexec linked an issue Dec 16, 2020 that may be closed by this pull request
Difficulty scaling when running many workflows and/or steps #4634
Closed
@alexec alexec merged commit 69ce2ac into argoproj:master Dec 16, 2020
@alexec alexec deleted the gc-queue branch December 16, 2020 22:52
@alexec alexec mentioned this pull request Dec 17, 2020
Closed
@simster7 simster7 mentioned this pull request Dec 17, 2020
Closed
9 tasks
@simster7 simster7 mentioned this pull request Jan 4, 2021
Closed
21 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarabala1979 sarabala1979 sarabala1979 approved these changes

Assignees

@sarabala1979 sarabala1979

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Difficulty scaling when running many workflows and/or steps
2 participants
@alexec @sarabala1979