chore(example): Add watch timeout and print out workflow status message #4740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexec
reviewed
Dec 14, 2020
examples/example-golang/main.go
Outdated
| @@ -68,6 +68,10 @@ func main() { | |||
| if !ok { | |||
| continue | |||
| } | |||
| if wf.Status.Phase == wfv1.NodeFailed || wf.Status.Phase == wfv1.NodeError { | |||
There was a problem hiding this comment.
won't the block on line 75 also catch this?
There was a problem hiding this comment.
That's true. I was debugging why the example has been running forever and turns out that the problem is something else. I have updated this PR to print out the detailed error message from the status and added the timeout to the watch to improve the usability of this example. Let me know what you think.
terrytangyuan
changed the title
terrytangyuan
changed the title
Signed-off-by: terrytangyuan <terrytangyuan@gmail.com>
alexec
reviewed
Dec 15, 2020
examples/example-golang/main.go
Outdated
| @@ -70,6 +71,9 @@ func main() { | |||
| } | |||
| if !wf.Status.FinishedAt.IsZero() { | |||
| fmt.Printf("Workflow %s %s at %v\n", wf.Name, wf.Status.Phase, wf.Status.FinishedAt) | |||
| if wf.Status.Phase == wfv1.NodeFailed || wf.Status.Phase == wfv1.NodeError { | |||
| fmt.Printf("Workflow %s failed due to: %s", wf.Name, wf.Status.Message) | |||
There was a problem hiding this comment.
could you just add the wf.Status.Message to line 74?
Signed-off-by: terrytangyuan <terrytangyuan@gmail.com>
terrytangyuan
changed the title
alexec
approved these changes
Dec 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The workflow in the current example would only exit the loop when it reaches completion. It's better to exit loop immediately when the workflow has failed.
Signed-off-by: terrytangyuan terrytangyuan@gmail.com
Checklist: