Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(controller): Requeue when the pod was deleted. Fixes #4719 #4742

Merged
merged 2 commits into from
Dec 15, 2020
Merged

fix(controller): Requeue when the pod was deleted. Fixes #4719 #4742

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c0e65e3
fix(controller): Requeue when the pod was deleted.
alexec Dec 15, 2020
b3b2738
Update operator.go
alexec Dec 15, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
9 changes: 8 additions & 1 deletion workflow/controller/operator.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -916,7 +916,14 @@ func (woc *wfOperationCtx) podReconciliation() error {

// If the node is pending and the pod does not exist, it could be the case that we want to try to submit it
// again instead of marking it as an error. Check if that's the case.
if node.Pending() || recentlyStarted {
if node.Pending() {
continue
}
if recentlyStarted {
// If the pod was deleted, then we it is possible that the controller never get another informer message about it.
// In this case, the workflow will only be requeued after the resync period (20m). This means
// workflow will not update for 20m. Requeuing here prevents that happening.
woc.requeue(defaultRequeueTime)
continue
}

Expand Down