Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(ui): replace node-sass with sass #4780

Merged
merged 1 commit into from Dec 19, 2020

Conversation

dcherman
Copy link
Member

The usage of node-sass has been superceded by sass in newer
versions of sass-loader. sass is a pure JS implementation whereas
node-sass requires compilation or pre-built bindings to be available
which can complicate usage depending on your environment (such as the
environment where brew packages are built).

Signed-off-by: Daniel Herman dherman@factset.com

The usage of `node-sass` has been superceded by `sass` in newer
versions of sass-loader.  `sass` is a pure JS implementation whereas
`node-sass` requires compilation or pre-built bindings to be available
which can complicate usage depending on your environment (such as the
environment where brew packages are built).

Signed-off-by: Daniel Herman <dherman@factset.com>
@alexec alexec self-assigned this Dec 19, 2020
Copy link
Contributor

@alexec alexec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works!

@alexec alexec merged commit af03a74 into argoproj:master Dec 19, 2020
@dcherman dcherman deleted the refactor/sass branch December 19, 2020 00:42
@simster7 simster7 mentioned this pull request Jan 4, 2021
21 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants