Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: load all supported authentication plugins for k8s client-go #4802

Merged
merged 3 commits into from Dec 29, 2020
Merged

fix: load all supported authentication plugins for k8s client-go #4802

merged 3 commits into from Dec 29, 2020

Conversation

krijohs
Copy link
Contributor

@krijohs krijohs commented Dec 26, 2020

Signed-off-by: kristoffer johansson johanson.kristoffer@gmail.com

Fix for loading authentication plugins for k8s client-go. Import all supported plugins instead of specific ones. Closes (#4531)

Signed-off-by: kristoffer johansson <johanson.kristoffer@gmail.com>
@CLAassistant
Copy link

CLAassistant commented Dec 26, 2020

CLA assistant check
All committers have signed the CLA.

@krijohs krijohs changed the title Fix load all supported authentication plugins for k8s client-go fix: load all supported authentication plugins for k8s client-go Dec 26, 2020
@alexec
Copy link
Contributor

alexec commented Dec 29, 2020

Looks good so far, you need to apply this patch to fix your code gen:

diff --git a/cmd/workflow-controller/main.go b/cmd/workflow-controller/main.go
index 65e90ec1..d8d55489 100644
--- a/cmd/workflow-controller/main.go
+++ b/cmd/workflow-controller/main.go
@@ -13,6 +13,7 @@ import (
 	log "github.com/sirupsen/logrus"
 	"github.com/spf13/cobra"
 	"k8s.io/client-go/kubernetes"
+
 	// load authentication plugin for obtaining credentials from cloud providers.
 	_ "k8s.io/client-go/plugin/pkg/client/auth"
 	"k8s.io/client-go/tools/clientcmd"

Copy link
Contributor

@alexec alexec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment.

Signed-off-by: kristoffer johansson <johanson.kristoffer@gmail.com>
@alexec alexec merged commit 7e6c799 into argoproj:master Dec 29, 2020
@alexec alexec added this to the v3.0 milestone Dec 29, 2020
@simster7 simster7 mentioned this pull request Jan 4, 2021
21 tasks
simster7 pushed a commit that referenced this pull request Jan 4, 2021
Signed-off-by: kristoffer johansson <johanson.kristoffer@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants